Message ID | 20191003215227.23540-1-colin.king@canonical.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [next] drm/amdgpu: fix uninitialized variable pasid_mapping_needed | expand |
Am 03.10.19 um 23:52 schrieb Colin King: > From: Colin Ian King <colin.king@canonical.com> > > The boolean variable pasid_mapping_needed is not initialized and > there are code paths that do not assign it any value before it is > is read later. Fix this by initializing pasid_mapping_needed to > false. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 6817bf283b2b ("drm/amdgpu: grab the id mgr lock while accessing passid_mapping") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Christian König <christian.koenig@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > index a2c797e34a29..be10e4b9a94d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > @@ -1055,7 +1055,7 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job, > id->oa_size != job->oa_size); > bool vm_flush_needed = job->vm_needs_flush; > struct dma_fence *fence = NULL; > - bool pasid_mapping_needed; > + bool pasid_mapping_needed = false; > unsigned patch_offset = 0; > int r; >
On Fri, Oct 4, 2019 at 3:28 AM Koenig, Christian <Christian.Koenig@amd.com> wrote: > > Am 03.10.19 um 23:52 schrieb Colin King: > > From: Colin Ian King <colin.king@canonical.com> > > > > The boolean variable pasid_mapping_needed is not initialized and > > there are code paths that do not assign it any value before it is > > is read later. Fix this by initializing pasid_mapping_needed to > > false. > > > > Addresses-Coverity: ("Uninitialized scalar variable") > > Fixes: 6817bf283b2b ("drm/amdgpu: grab the id mgr lock while accessing passid_mapping") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Reviewed-by: Christian König <christian.koenig@amd.com> > Applied. thanks! Alex > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > index a2c797e34a29..be10e4b9a94d 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > @@ -1055,7 +1055,7 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job, > > id->oa_size != job->oa_size); > > bool vm_flush_needed = job->vm_needs_flush; > > struct dma_fence *fence = NULL; > > - bool pasid_mapping_needed; > > + bool pasid_mapping_needed = false; > > unsigned patch_offset = 0; > > int r; > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index a2c797e34a29..be10e4b9a94d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -1055,7 +1055,7 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job, id->oa_size != job->oa_size); bool vm_flush_needed = job->vm_needs_flush; struct dma_fence *fence = NULL; - bool pasid_mapping_needed; + bool pasid_mapping_needed = false; unsigned patch_offset = 0; int r;