remoteproc: Fix wrong rvring index computation
diff mbox series

Message ID 20191004073736.8327-1-cleger@kalray.eu
State Accepted
Commit 00a0eec59ddbb1ce966b19097d8a8d2f777e726a
Headers show
Series
  • remoteproc: Fix wrong rvring index computation
Related show

Commit Message

Clement Leger Oct. 4, 2019, 7:37 a.m. UTC
Index of rvring is computed using pointer arithmetic. However, since
rvring->rvdev->vring is the base of the vring array, computation
of rvring idx should be reversed. It previously lead to writing at negative
indices in the resource table.

Signed-off-by: Clement Leger <cleger@kalray.eu>
---
 drivers/remoteproc/remoteproc_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+linux-remoteproc@kernel.org Nov. 21, 2019, 6:20 p.m. UTC | #1
Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next).

On Fri,  4 Oct 2019 09:37:36 +0200 you wrote:
> Index of rvring is computed using pointer arithmetic. However, since
> rvring->rvdev->vring is the base of the vring array, computation
> of rvring idx should be reversed. It previously lead to writing at negative
> indices in the resource table.
> 
> Signed-off-by: Clement Leger <cleger@kalray.eu>
> 
> [...]


Here is a summary with links:
  - remoteproc: Fix wrong rvring index computation
    https://git.kernel.org/andersson/remoteproc/c/00a0eec59ddbb1ce966b19097d8a8d2f777e726a

You are awesome, thank you!

Patch
diff mbox series

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 3c5fbbbfb0f1..ab7443874635 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -400,7 +400,7 @@  rproc_parse_vring(struct rproc_vdev *rvdev, struct fw_rsc_vdev *rsc, int i)
 void rproc_free_vring(struct rproc_vring *rvring)
 {
 	struct rproc *rproc = rvring->rvdev->rproc;
-	int idx = rvring->rvdev->vring - rvring;
+	int idx = rvring - rvring->rvdev->vring;
 	struct fw_rsc_vdev *rsc;
 
 	idr_remove(&rproc->notifyids, rvring->notifyid);