| Message ID | 20191004141914.20600-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] drm/edid: Make drm_get_cea_aspect_ratio() static | expand |
>-----Original Message----- >From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Ville Syrjala >Sent: Friday, October 4, 2019 7:49 PM >To: dri-devel@lists.freedesktop.org >Cc: intel-gfx@lists.freedesktop.org; Wayne Lin <waynelin@amd.com> >Subject: [PATCH 1/4] drm/edid: Make drm_get_cea_aspect_ratio() static > >From: Ville Syrjälä <ville.syrjala@linux.intel.com> > >drm_get_cea_aspect_ratio() is not used outside drm_edid.c. >Make it static. Change looks good to me. Reviewed-by: Uma Shankar <uma.shankar@intel.com> >Cc: Wayne Lin <waynelin@amd.com> >Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> >--- > drivers/gpu/drm/drm_edid.c | 10 +--------- > include/drm/drm_edid.h | 1 - > 2 files changed, 1 insertion(+), 10 deletions(-) > >diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index >0552175313cb..3df8267adab9 100644 >--- a/drivers/gpu/drm/drm_edid.c >+++ b/drivers/gpu/drm/drm_edid.c >@@ -3205,18 +3205,10 @@ static bool drm_valid_cea_vic(u8 vic) > return vic > 0 && vic < ARRAY_SIZE(edid_cea_modes); } > >-/** >- * drm_get_cea_aspect_ratio - get the picture aspect ratio corresponding to >- * the input VIC from the CEA mode list >- * @video_code: ID given to each of the CEA modes >- * >- * Returns picture aspect ratio >- */ >-enum hdmi_picture_aspect drm_get_cea_aspect_ratio(const u8 video_code) >+static enum hdmi_picture_aspect drm_get_cea_aspect_ratio(const u8 >+video_code) > { > return edid_cea_modes[video_code].picture_aspect_ratio; > } >-EXPORT_SYMBOL(drm_get_cea_aspect_ratio); > > /* > * Calculate the alternate clock for HDMI modes (those from the HDMI vendor diff -- >git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index >b9719418c3d2..efce675abf07 100644 >--- a/include/drm/drm_edid.h >+++ b/include/drm/drm_edid.h >@@ -481,7 +481,6 @@ int drm_add_edid_modes(struct drm_connector *connector, >struct edid *edid); int drm_add_override_edid_modes(struct drm_connector >*connector); > > u8 drm_match_cea_mode(const struct drm_display_mode *to_match); -enum >hdmi_picture_aspect drm_get_cea_aspect_ratio(const u8 video_code); bool >drm_detect_hdmi_monitor(struct edid *edid); bool >drm_detect_monitor_audio(struct edid *edid); enum hdmi_quantization_range >-- >2.21.0 > >_______________________________________________ >dri-devel mailing list >dri-devel@lists.freedesktop.org >https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 0552175313cb..3df8267adab9 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3205,18 +3205,10 @@ static bool drm_valid_cea_vic(u8 vic) return vic > 0 && vic < ARRAY_SIZE(edid_cea_modes); } -/** - * drm_get_cea_aspect_ratio - get the picture aspect ratio corresponding to - * the input VIC from the CEA mode list - * @video_code: ID given to each of the CEA modes - * - * Returns picture aspect ratio - */ -enum hdmi_picture_aspect drm_get_cea_aspect_ratio(const u8 video_code) +static enum hdmi_picture_aspect drm_get_cea_aspect_ratio(const u8 video_code) { return edid_cea_modes[video_code].picture_aspect_ratio; } -EXPORT_SYMBOL(drm_get_cea_aspect_ratio); /* * Calculate the alternate clock for HDMI modes (those from the HDMI vendor diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index b9719418c3d2..efce675abf07 100644 --- a/include/drm/drm_edid.h +++ b/include/drm/drm_edid.h @@ -481,7 +481,6 @@ int drm_add_edid_modes(struct drm_connector *connector, struct edid *edid); int drm_add_override_edid_modes(struct drm_connector *connector); u8 drm_match_cea_mode(const struct drm_display_mode *to_match); -enum hdmi_picture_aspect drm_get_cea_aspect_ratio(const u8 video_code); bool drm_detect_hdmi_monitor(struct edid *edid); bool drm_detect_monitor_audio(struct edid *edid); enum hdmi_quantization_range