| Message ID | 20191004145056.43267-7-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | efi/firmware/platform-x86: Add EFI embedded fw support | expand |
On Fri, Oct 04, 2019 at 04:50:54PM +0200, Hans de Goede wrote: > Unfortunately sofar we have been unable to get permission to redistribute > icn8505 touchscreen firmwares in linux-firmware. This means that people > need to find and install the firmware themselves before the touchscreen > will work > > Some UEFI/x86 tablets with an icn8505 touchscreen have a copy of the fw > embedded in their UEFI boot-services code. > > This commit makes the icn8505 driver use the new firmware_request_platform > function, which will fallback to looking for such an embedded copy when > direct filesystem lookup fails. This will make the touchscreen work OOTB > on devices where there is a fw copy embedded in the UEFI code. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Feel free to merge with the rest of the series. > --- > drivers/input/touchscreen/chipone_icn8505.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/chipone_icn8505.c b/drivers/input/touchscreen/chipone_icn8505.c > index c768186ce856..f9ca5502ac8c 100644 > --- a/drivers/input/touchscreen/chipone_icn8505.c > +++ b/drivers/input/touchscreen/chipone_icn8505.c > @@ -288,7 +288,7 @@ static int icn8505_upload_fw(struct icn8505_data *icn8505) > * we may need it at resume. Having loaded it once will make the > * firmware class code cache it at suspend/resume. > */ > - error = request_firmware(&fw, icn8505->firmware_name, dev); > + error = firmware_request_platform(&fw, icn8505->firmware_name, dev); > if (error) { > dev_err(dev, "Firmware request error %d\n", error); > return error; > -- > 2.23.0 >
diff --git a/drivers/input/touchscreen/chipone_icn8505.c b/drivers/input/touchscreen/chipone_icn8505.c index c768186ce856..f9ca5502ac8c 100644 --- a/drivers/input/touchscreen/chipone_icn8505.c +++ b/drivers/input/touchscreen/chipone_icn8505.c @@ -288,7 +288,7 @@ static int icn8505_upload_fw(struct icn8505_data *icn8505) * we may need it at resume. Having loaded it once will make the * firmware class code cache it at suspend/resume. */ - error = request_firmware(&fw, icn8505->firmware_name, dev); + error = firmware_request_platform(&fw, icn8505->firmware_name, dev); if (error) { dev_err(dev, "Firmware request error %d\n", error); return error;
Unfortunately sofar we have been unable to get permission to redistribute icn8505 touchscreen firmwares in linux-firmware. This means that people need to find and install the firmware themselves before the touchscreen will work Some UEFI/x86 tablets with an icn8505 touchscreen have a copy of the fw embedded in their UEFI boot-services code. This commit makes the icn8505 driver use the new firmware_request_platform function, which will fallback to looking for such an embedded copy when direct filesystem lookup fails. This will make the touchscreen work OOTB on devices where there is a fw copy embedded in the UEFI code. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/input/touchscreen/chipone_icn8505.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)