| Message ID | 20191007131649.1768-3-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Odroid N2 failes to boot using upstream kernel & u-boot | expand |
On 07/10/2019 15:16, Anand Moon wrote: > As per schematics add missing VDDCPUA_PWM and VDDCPUB_PWM > gpio signal use to enable/disable the pwm regulator for DVFS. > > Fixes: d14734a04a8a (arm64: dts: meson-g12b-odroid-n2: enable DVFS) > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > index a9a661258886..66262a6ab3fe 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > @@ -135,6 +135,8 @@ > > regulator-boot-on; > regulator-always-on; > + /* VDDCPUA_PWM */ > + enable-gpios = <&gpio GPIOE_1 GPIO_ACTIVE_HIGH>; > }; > > vddcpu_b: regulator-vddcpu-b { > @@ -154,6 +156,8 @@ > > regulator-boot-on; > regulator-always-on; > + /* VDDCPUB_PWM */ > + enable-gpios = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>; > }; > > hub_5v: regulator-hub_5v { > Same as 5V_EN, This GPIO is handled by the BL301 SCP firmware, I'm personally against adding this to the DT since it's out of control of Linux or any OS. This GPIO id controlles by the PSCI call to SCP to enable/disable the CPU clusters. Neil
Hi Neil, On Mon, 7 Oct 2019 at 19:50, Neil Armstrong <narmstrong@baylibre.com> wrote: > > On 07/10/2019 15:16, Anand Moon wrote: > > As per schematics add missing VDDCPUA_PWM and VDDCPUB_PWM > > gpio signal use to enable/disable the pwm regulator for DVFS. > > > > Fixes: d14734a04a8a (arm64: dts: meson-g12b-odroid-n2: enable DVFS) > > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > Cc: Jerome Brunet <jbrunet@baylibre.com> > > Cc: Neil Armstrong <narmstrong@baylibre.com> > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > index a9a661258886..66262a6ab3fe 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > @@ -135,6 +135,8 @@ > > > > regulator-boot-on; > > regulator-always-on; > > + /* VDDCPUA_PWM */ > > + enable-gpios = <&gpio GPIOE_1 GPIO_ACTIVE_HIGH>; > > }; > > > > vddcpu_b: regulator-vddcpu-b { > > @@ -154,6 +156,8 @@ > > > > regulator-boot-on; > > regulator-always-on; > > + /* VDDCPUB_PWM */ > > + enable-gpios = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>; > > }; > > > > hub_5v: regulator-hub_5v { > > > > Same as 5V_EN, This GPIO is handled by the BL301 SCP firmware, I'm personally against > adding this to the DT since it's out of control of Linux or any OS. > > This GPIO id controlles by the PSCI call to SCP to enable/disable > the CPU clusters. > > Neil Thanks for your input's. Best Regards -Anand
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts index a9a661258886..66262a6ab3fe 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts @@ -135,6 +135,8 @@ regulator-boot-on; regulator-always-on; + /* VDDCPUA_PWM */ + enable-gpios = <&gpio GPIOE_1 GPIO_ACTIVE_HIGH>; }; vddcpu_b: regulator-vddcpu-b { @@ -154,6 +156,8 @@ regulator-boot-on; regulator-always-on; + /* VDDCPUB_PWM */ + enable-gpios = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>; }; hub_5v: regulator-hub_5v {
As per schematics add missing VDDCPUA_PWM and VDDCPUB_PWM gpio signal use to enable/disable the pwm regulator for DVFS. Fixes: d14734a04a8a (arm64: dts: meson-g12b-odroid-n2: enable DVFS) Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: Jerome Brunet <jbrunet@baylibre.com> Cc: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 4 ++++ 1 file changed, 4 insertions(+)