[01/24] golang/xenlight: fix calls to libxl_domain_unpause/pause
diff mbox series

Message ID 5c509297c01b8931986b1d039de1c72e89e44037.1570456846.git.rosbrookn@ainfosec.com
State New
Headers show
Series
  • generated Go libxl bindings using IDL
Related show

Commit Message

Nick Rosbrook Oct. 7, 2019, 3:12 p.m. UTC
From: Nick Rosbrook <rosbrookn@ainfosec.com>

These functions require a third argument of type const *libxl_asyncop_how.

Pass nil to fix compilation errors. This will have the effect of
performing these operations synchronously.

Signed-off-by: Nick Rosbrook <rosbrookn@ainfosec.com>
---
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wl@xen.org>

 tools/golang/xenlight/xenlight.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

George Dunlap Oct. 7, 2019, 4:39 p.m. UTC | #1
On 10/7/19 4:12 PM, Nick Rosbrook wrote:
> From: Nick Rosbrook <rosbrookn@ainfosec.com>
> 
> These functions require a third argument of type const *libxl_asyncop_how.
> 
> Pass nil to fix compilation errors. This will have the effect of
> performing these operations synchronously.
> 
> Signed-off-by: Nick Rosbrook <rosbrookn@ainfosec.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>

Juergen, this is actually a bug fix (these lines didn't get updated when
the API changed), so I'm going to check this in later this week if you
don't object.

> ---
> Cc: George Dunlap <george.dunlap@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wl@xen.org>
> 
>  tools/golang/xenlight/xenlight.go | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go
> index f5d171c2d5..59b8186a64 100644
> --- a/tools/golang/xenlight/xenlight.go
> +++ b/tools/golang/xenlight/xenlight.go
> @@ -1011,7 +1011,7 @@ func (Ctx *Context) DomainUnpause(Id Domid) (err error) {
>  		return
>  	}
>  
> -	ret := C.libxl_domain_unpause(Ctx.ctx, C.uint32_t(Id))
> +	ret := C.libxl_domain_unpause(Ctx.ctx, C.uint32_t(Id), nil)
>  
>  	if ret != 0 {
>  		err = Error(-ret)
> @@ -1026,7 +1026,7 @@ func (Ctx *Context) DomainPause(id Domid) (err error) {
>  		return
>  	}
>  
> -	ret := C.libxl_domain_pause(Ctx.ctx, C.uint32_t(id))
> +	ret := C.libxl_domain_pause(Ctx.ctx, C.uint32_t(id), nil)
>  
>  	if ret != 0 {
>  		err = Error(-ret)
>
Jürgen Groß Oct. 8, 2019, 4:17 a.m. UTC | #2
On 07.10.19 18:39, George Dunlap wrote:
> On 10/7/19 4:12 PM, Nick Rosbrook wrote:
>> From: Nick Rosbrook <rosbrookn@ainfosec.com>
>>
>> These functions require a third argument of type const *libxl_asyncop_how.
>>
>> Pass nil to fix compilation errors. This will have the effect of
>> performing these operations synchronously.
>>
>> Signed-off-by: Nick Rosbrook <rosbrookn@ainfosec.com>
> 
> Reviewed-by: George Dunlap <george.dunlap@citrix.com>
> 
> Juergen, this is actually a bug fix (these lines didn't get updated when
> the API changed), so I'm going to check this in later this week if you
> don't object.

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

Patch
diff mbox series

diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go
index f5d171c2d5..59b8186a64 100644
--- a/tools/golang/xenlight/xenlight.go
+++ b/tools/golang/xenlight/xenlight.go
@@ -1011,7 +1011,7 @@  func (Ctx *Context) DomainUnpause(Id Domid) (err error) {
 		return
 	}
 
-	ret := C.libxl_domain_unpause(Ctx.ctx, C.uint32_t(Id))
+	ret := C.libxl_domain_unpause(Ctx.ctx, C.uint32_t(Id), nil)
 
 	if ret != 0 {
 		err = Error(-ret)
@@ -1026,7 +1026,7 @@  func (Ctx *Context) DomainPause(id Domid) (err error) {
 		return
 	}
 
-	ret := C.libxl_domain_pause(Ctx.ctx, C.uint32_t(id))
+	ret := C.libxl_domain_pause(Ctx.ctx, C.uint32_t(id), nil)
 
 	if ret != 0 {
 		err = Error(-ret)