| Message ID | 20191007171224.1581-2-sam@ravnborg.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | : Finally delete drmP.h | expand |
On Mon, Oct 07, 2019 at 07:12:23PM +0200, Sam Ravnborg wrote: > drmP.h is deprecated and will be deleted. > Replace use with proper header. > > Divide header includes in blocks while touching these. > > Build tested with various archtectures and configs. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Sean Paul <sean@poorly.run> > Fixes: ae85b0df124f6928 ("drm_dp_cec: add connector info support.") > Cc: Dariusz Marcinkiewicz <darekm@google.com> > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: Lyude Paul <lyude@redhat.com> > Cc: Ben Skeggs <bskeggs@redhat.com> > --- > drivers/gpu/drm/drm_dp_cec.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_cec.c b/drivers/gpu/drm/drm_dp_cec.c > index b457c16c3a8b..3ab2609f9ec7 100644 > --- a/drivers/gpu/drm/drm_dp_cec.c > +++ b/drivers/gpu/drm/drm_dp_cec.c > @@ -8,10 +8,12 @@ > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/slab.h> > + > +#include <media/cec.h> > + > #include <drm/drm_connector.h> > +#include <drm/drm_device.h> > #include <drm/drm_dp_helper.h> > -#include <drm/drmP.h> > -#include <media/cec.h> > > /* > * Unfortunately it turns out that we have a chicken-and-egg situation > -- > 2.20.1 >
Reviewed-by: Lyude Paul <lyude@redhat.com> On Mon, 2019-10-07 at 19:12 +0200, Sam Ravnborg wrote: > drmP.h is deprecated and will be deleted. > Replace use with proper header. > > Divide header includes in blocks while touching these. > > Build tested with various archtectures and configs. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Fixes: ae85b0df124f6928 ("drm_dp_cec: add connector info support.") > Cc: Dariusz Marcinkiewicz <darekm@google.com> > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: Lyude Paul <lyude@redhat.com> > Cc: Ben Skeggs <bskeggs@redhat.com> > --- > drivers/gpu/drm/drm_dp_cec.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_cec.c b/drivers/gpu/drm/drm_dp_cec.c > index b457c16c3a8b..3ab2609f9ec7 100644 > --- a/drivers/gpu/drm/drm_dp_cec.c > +++ b/drivers/gpu/drm/drm_dp_cec.c > @@ -8,10 +8,12 @@ > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/slab.h> > + > +#include <media/cec.h> > + > #include <drm/drm_connector.h> > +#include <drm/drm_device.h> > #include <drm/drm_dp_helper.h> > -#include <drm/drmP.h> > -#include <media/cec.h> > > /* > * Unfortunately it turns out that we have a chicken-and-egg situation
On 10/7/19 7:12 PM, Sam Ravnborg wrote: > drmP.h is deprecated and will be deleted. > Replace use with proper header. > > Divide header includes in blocks while touching these. > > Build tested with various archtectures and configs. Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Regards, Hans > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Fixes: ae85b0df124f6928 ("drm_dp_cec: add connector info support.") > Cc: Dariusz Marcinkiewicz <darekm@google.com> > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: Lyude Paul <lyude@redhat.com> > Cc: Ben Skeggs <bskeggs@redhat.com> > --- > drivers/gpu/drm/drm_dp_cec.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_cec.c b/drivers/gpu/drm/drm_dp_cec.c > index b457c16c3a8b..3ab2609f9ec7 100644 > --- a/drivers/gpu/drm/drm_dp_cec.c > +++ b/drivers/gpu/drm/drm_dp_cec.c > @@ -8,10 +8,12 @@ > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/slab.h> > + > +#include <media/cec.h> > + > #include <drm/drm_connector.h> > +#include <drm/drm_device.h> > #include <drm/drm_dp_helper.h> > -#include <drm/drmP.h> > -#include <media/cec.h> > > /* > * Unfortunately it turns out that we have a chicken-and-egg situation >
diff --git a/drivers/gpu/drm/drm_dp_cec.c b/drivers/gpu/drm/drm_dp_cec.c index b457c16c3a8b..3ab2609f9ec7 100644 --- a/drivers/gpu/drm/drm_dp_cec.c +++ b/drivers/gpu/drm/drm_dp_cec.c @@ -8,10 +8,12 @@ #include <linux/kernel.h> #include <linux/module.h> #include <linux/slab.h> + +#include <media/cec.h> + #include <drm/drm_connector.h> +#include <drm/drm_device.h> #include <drm/drm_dp_helper.h> -#include <drm/drmP.h> -#include <media/cec.h> /* * Unfortunately it turns out that we have a chicken-and-egg situation
drmP.h is deprecated and will be deleted. Replace use with proper header. Divide header includes in blocks while touching these. Build tested with various archtectures and configs. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Fixes: ae85b0df124f6928 ("drm_dp_cec: add connector info support.") Cc: Dariusz Marcinkiewicz <darekm@google.com> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: Lyude Paul <lyude@redhat.com> Cc: Ben Skeggs <bskeggs@redhat.com> --- drivers/gpu/drm/drm_dp_cec.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)