| Message ID | 20191009142748.18005-2-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/8] xfs: pass the correct flag to xlog_write_iclog | expand |
On Wed, Oct 09, 2019 at 04:27:41PM +0200, Christoph Hellwig wrote: > xlog_write_iclog expects a bool for the second argument. While any > non-0 value happens to work fine this makes all calls consistent. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > fs/xfs/xfs_log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c > index a2beee9f74da..cd90871c2101 100644 > --- a/fs/xfs/xfs_log.c > +++ b/fs/xfs/xfs_log.c > @@ -1735,7 +1735,7 @@ xlog_write_iclog( > * the buffer manually, the code needs to be kept in sync > * with the I/O completion path. > */ > - xlog_state_done_syncing(iclog, XFS_LI_ABORTED); > + xlog_state_done_syncing(iclog, true); > up(&iclog->ic_sema); > return; > } > -- > 2.20.1 >
On Wed, Oct 09, 2019 at 04:27:41PM +0200, Christoph Hellwig wrote: > xlog_write_iclog expects a bool for the second argument. While any > non-0 value happens to work fine this makes all calls consistent. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- Reviewed-by: Brian Foster <bfoster@redhat.com> > fs/xfs/xfs_log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c > index a2beee9f74da..cd90871c2101 100644 > --- a/fs/xfs/xfs_log.c > +++ b/fs/xfs/xfs_log.c > @@ -1735,7 +1735,7 @@ xlog_write_iclog( > * the buffer manually, the code needs to be kept in sync > * with the I/O completion path. > */ > - xlog_state_done_syncing(iclog, XFS_LI_ABORTED); > + xlog_state_done_syncing(iclog, true); > up(&iclog->ic_sema); > return; > } > -- > 2.20.1 >
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index a2beee9f74da..cd90871c2101 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c @@ -1735,7 +1735,7 @@ xlog_write_iclog( * the buffer manually, the code needs to be kept in sync * with the I/O completion path. */ - xlog_state_done_syncing(iclog, XFS_LI_ABORTED); + xlog_state_done_syncing(iclog, true); up(&iclog->ic_sema); return; }
xlog_write_iclog expects a bool for the second argument. While any non-0 value happens to work fine this makes all calls consistent. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/xfs_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)