null_blk: Fix zoned command return code
diff mbox series

Message ID 20191009153813.4854-1-kbusch@kernel.org
State New
Headers show
Series
  • null_blk: Fix zoned command return code
Related show

Commit Message

Keith Busch Oct. 9, 2019, 3:38 p.m. UTC
From: Keith Busch <kbusch@kernel.org>

The return code from null_handle_zoned() sets the cmd->error value. Returning
OK status when an error occured overwrites the intended cmd->error. Return the
appropriate error code instead of setting the error in the cmd.

Fixes: fceb5d1b19cbe626 ("null_blk: create a helper for zoned devices")
Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 drivers/block/null_blk_zoned.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Jens Axboe Oct. 10, 2019, 2:59 a.m. UTC | #1
On 10/9/19 9:38 AM, kbusch@kernel.org wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> The return code from null_handle_zoned() sets the cmd->error value. Returning
> OK status when an error occured overwrites the intended cmd->error. Return the
> appropriate error code instead of setting the error in the cmd.

Applied, thanks.

Patch
diff mbox series

diff --git a/drivers/block/null_blk_zoned.c b/drivers/block/null_blk_zoned.c
index eabc116832a7..3d7fdea872f8 100644
--- a/drivers/block/null_blk_zoned.c
+++ b/drivers/block/null_blk_zoned.c
@@ -142,8 +142,7 @@  static blk_status_t null_zone_reset(struct nullb_cmd *cmd, sector_t sector)
 		zone->wp = zone->start;
 		break;
 	default:
-		cmd->error = BLK_STS_NOTSUPP;
-		break;
+		return BLK_STS_NOTSUPP;
 	}
 	return BLK_STS_OK;
 }