[1/2] drm/i915/tgl: the BCS engine supports relative MMIO
diff mbox series

Message ID 20191009230424.6507-1-daniele.ceraolospurio@intel.com
State New
Headers show
Series
  • [1/2] drm/i915/tgl: the BCS engine supports relative MMIO
Related show

Commit Message

Daniele Ceraolo Spurio Oct. 9, 2019, 11:04 p.m. UTC
The specs don't mention any specific HW limitation on the blitter and
manual inspection shows that the HW does set the relative MMIO bit in
the LRI of the blitter context image, so we can remove our limitations.

Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 drivers/gpu/drm/i915/gt/intel_lrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Wilson Oct. 10, 2019, 8:49 a.m. UTC | #1
Quoting Daniele Ceraolo Spurio (2019-10-10 00:04:23)
> The specs don't mention any specific HW limitation on the blitter and
> manual inspection shows that the HW does set the relative MMIO bit in
> the LRI of the blitter context image, so we can remove our limitations.

I concur, the HW itself sets the bit, so it can't be too harmful...

> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
Chris Wilson Oct. 10, 2019, 9:17 a.m. UTC | #2
Quoting Patchwork (2019-10-10 03:08:10)
> == Series Details ==
> 
> Series: series starting with [1/2] drm/i915/tgl: the BCS engine supports relative MMIO
> URL   : https://patchwork.freedesktop.org/series/67809/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7046 -> Patchwork_14739
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**
> 
>   No regressions found.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14739/index.html

That's enough (boots and live_lrc found no inconsistencies) convincing,
pushed.
-Chris

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 6db762c509b8..78a136c12385 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -3448,7 +3448,7 @@  void intel_execlists_set_default_submission(struct intel_engine_cs *engine)
 			engine->flags |= I915_ENGINE_HAS_PREEMPTION;
 	}
 
-	if (engine->class != COPY_ENGINE_CLASS && INTEL_GEN(engine->i915) >= 12)
+	if (INTEL_GEN(engine->i915) >= 12)
 		engine->flags |= I915_ENGINE_HAS_RELATIVE_MMIO;
 }