From patchwork Thu Oct 10 10:30:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 11183077 X-Patchwork-Delegate: viresh.linux@gmail.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 559DB76 for ; Thu, 10 Oct 2019 10:31:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3608E2054F for ; Thu, 10 Oct 2019 10:31:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A3Ccp5m0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbfJJKbC (ORCPT ); Thu, 10 Oct 2019 06:31:02 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:45441 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbfJJKbC (ORCPT ); Thu, 10 Oct 2019 06:31:02 -0400 Received: by mail-pl1-f195.google.com with SMTP id u12so2554651pls.12 for ; Thu, 10 Oct 2019 03:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HkxBDeI13PS/unHL1Nr+Sh+9tXf4QbZkcMWKpQOyoZs=; b=A3Ccp5m0GI0vf9vINUCaNgrXVyXgcdJaG3xHrIHMVAavr6PGkGIk2Rnv8iPDi14niy DeIrUZ5K3Q1T7ubCWBcWkWX8JmKwbimhiuLo0lm4549GDL1CKjT06RlAALVfrRDR5u7n FJ+AGVq+D276MDy6CMC86mTU+GOmxPFdikGggsEMOufzYdp5kj2OID/tuyMnSKV8Iikj c4hhdJW6rUhKvSG89tn4nMcBIbT54aJbpI5/7GZeJCjtchMX7zI0INRAYVWCOtTBxQob ZScd8nGDewPTjXDz4bzQ9r8eT/lyHZ7WcKtDsJiRlvjMmq8NMc2aTO+NmaEbxMel79G1 aycw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HkxBDeI13PS/unHL1Nr+Sh+9tXf4QbZkcMWKpQOyoZs=; b=qWgAYrWmon6a1/060NrTSwrRnnqa7edJgaBmx3lToPVWJjB5ScVf1Q6DI6y+fPogcq WmRm3QWveZ5S9blWA2Z2RvqG2T9RlQhoVCVgMgFZH0ePYr89uaR76/hkvWYdX7rVQBfz WLKUF6eFRyxNkCJ+/VMDiuFx0kisCRn776yCFM9Dj9A8fHhyOoffMcLrAEz3EIJs1lNC tFCcMtXjGS/zLVJJTgCfLpWE8GwMWwA1PrSpVfoX+nCgCKbtu8fCazrJQZBSTLHWhyYe IwlSdtHxhwMnSO/bHVwC+RLxPW0uxe4muMhtflzFIGEMCdwmPVlN/iuDf09QdXG/Fs0K hWMg== X-Gm-Message-State: APjAAAUG5WmSNEKKllRoNLK9vZvBNYNdOLBzz3YMaShlyV4NpkK9hlcE C5KXvCI8mDqCmNPg24VgYijtbw== X-Google-Smtp-Source: APXvYqzGw7DVSkGCo0+oVtm1TNRkmmIhKzdkzTs6guJGLgP3WTdjGG4hUW7yUT6AdCBxVIDYb7hllQ== X-Received: by 2002:a17:902:9a01:: with SMTP id v1mr8899294plp.132.1570703461455; Thu, 10 Oct 2019 03:31:01 -0700 (PDT) Received: from localhost ([122.172.151.112]) by smtp.gmail.com with ESMTPSA id q13sm10056498pjq.0.2019.10.10.03.30.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Oct 2019 03:31:00 -0700 (PDT) From: Viresh Kumar To: Viresh Kumar , Nishanth Menon , Stephen Boyd Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , "v5 . 0+" , Niklas Cassel , linux-kernel@vger.kernel.org Subject: [PATCH] opp: of: drop incorrect lockdep_assert_held() Date: Thu, 10 Oct 2019 16:00:52 +0530 Message-Id: <6306e18beab9deff6ee6b32f489390908495fe14.1570703431.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.21.0.rc0.269.g1a574e7a288b MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org _find_opp_of_np() doesn't traverse the list of OPP tables but instead just the entries within an OPP table and so only requires to lock the OPP table itself. The lockdep_assert_held() was added there by mistake and isn't really required. Fixes: 5d6d106fa455 ("OPP: Populate required opp tables from "required-opps" property") Cc: v5.0+ # v5.0+ Reported-by: Niklas Cassel Signed-off-by: Viresh Kumar Tested-by: Niklas Cassel --- drivers/opp/of.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/opp/of.c b/drivers/opp/of.c index 1813f5ad5fa2..6dc41faf74b5 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -77,8 +77,6 @@ static struct dev_pm_opp *_find_opp_of_np(struct opp_table *opp_table, { struct dev_pm_opp *opp; - lockdep_assert_held(&opp_table_lock); - mutex_lock(&opp_table->lock); list_for_each_entry(opp, &opp_table->opp_list, node) {