| Message ID | 20191010125300.2822-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names | expand |
On Thu, Oct 10, 2019 at 5:53 AM Fabio Estevam <festevam@gmail.com> wrote: > > According to Documentation/devicetree/bindings/iio/accel/mma8452.txt, > the correct interrupt-names are "INT1" and "INT2", so fix them > accordingly. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- > Hi Lucas/Andrey, > > I don't have access to this board, so please test it if you > have a chance. Will do. The binding documentation is actually a bit misleading since it makes it sounds like configuring both interrupts is a meaningful option, whereas in reality the driver will always use only one line. I've been meaning to submit a patch to re-word the documentation, maybe this is a good reminder that I need to do so. Do you mind if I re-spin a v2 of this patch and modify it to specify only a single IRQ line? Thanks, Andrey Smirnov
Hi Andrey, On Thu, Oct 10, 2019 at 5:35 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote: > Will do. The binding documentation is actually a bit misleading since > it makes it sounds like configuring both interrupts is a meaningful > option, whereas in reality the driver will always use only one line. > I've been meaning to submit a patch to re-word the documentation, > maybe this is a good reminder that I need to do so. Do you mind if I > re-spin a v2 of this patch and modify it to specify only a single IRQ > line? Please re-spin it. Thanks
diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi index 93be00a60c88..6fc7494931b9 100644 --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi @@ -358,7 +358,7 @@ compatible = "fsl,mma8451"; reg = <0x1c>; interrupt-parent = <&gpio1>; - interrupt-names = "int1", "int2"; + interrupt-names = "INT1", "INT2"; interrupts = <18 IRQ_TYPE_LEVEL_LOW>, <20 IRQ_TYPE_LEVEL_LOW>; };
According to Documentation/devicetree/bindings/iio/accel/mma8452.txt, the correct interrupt-names are "INT1" and "INT2", so fix them accordingly. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- Hi Lucas/Andrey, I don't have access to this board, so please test it if you have a chance. I realized this after debugging a mma8451 issue on sabreauto board and looking at other dts with mma8451 support. Thanks arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)