diff mbox series

[7/7] drm/dp-mst: fix warning on unused var

Message ID 20191011010907.103309-8-lucas.demarchi@intel.com (mailing list archive)
State New, archived
Headers show
Series Small fixes before fixing MST | expand

Commit Message

Lucas De Marchi Oct. 11, 2019, 1:09 a.m. UTC 
Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Lucas De Marchi Oct. 11, 2019, 5:58 p.m. UTC | #1 
+dri, +Daniel

On Thu, Oct 10, 2019 at 06:09:07PM -0700, Lucas De Marchi wrote:
>Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")
>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>---
> drivers/gpu/drm/drm_dp_mst_topology.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
>index 9364e4f42975..9cccc5e63309 100644
>--- a/drivers/gpu/drm/drm_dp_mst_topology.c
>+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
>@@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
> struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(struct drm_atomic_state *state,
> 								    struct drm_dp_mst_topology_mgr *mgr)
> {
>-	struct drm_device *dev = mgr->dev;
>-
> 	return to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr->base));
> }
> EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
>-- 
>2.23.0
>
Souza, Jose Oct. 11, 2019, 6:03 p.m. UTC | #2 
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

On Thu, 2019-10-10 at 18:09 -0700, Lucas De Marchi wrote:
> Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 9364e4f42975..9cccc5e63309 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
>  struct drm_dp_mst_topology_state
> *drm_atomic_get_mst_topology_state(struct drm_atomic_state *state,
>  								    str
> uct drm_dp_mst_topology_mgr *mgr)
>  {
> -	struct drm_device *dev = mgr->dev;
> -
>  	return
> to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state,
> &mgr->base));
>  }
>  EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
Daniel Vetter Oct. 14, 2019, 5:47 p.m. UTC | #3 
On Fri, Oct 11, 2019 at 10:58:13AM -0700, Lucas De Marchi wrote:
> +dri, +Daniel
> 
> On Thu, Oct 10, 2019 at 06:09:07PM -0700, Lucas De Marchi wrote:
> > Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > ---
> > drivers/gpu/drm/drm_dp_mst_topology.c | 2 --
> > 1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> > index 9364e4f42975..9cccc5e63309 100644
> > --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> > @@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
> > struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(struct drm_atomic_state *state,
> > 								    struct drm_dp_mst_topology_mgr *mgr)
> > {
> > -	struct drm_device *dev = mgr->dev;
> > -
> > 	return to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr->base));
> > }
> > EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);

Thanks for fixing this, pushed.
-Daniel

> > -- 
> > 2.23.0
> >
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 9364e4f42975..9cccc5e63309 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -4184,8 +4184,6 @@  EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
 struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(struct drm_atomic_state *state,
 								    struct drm_dp_mst_topology_mgr *mgr)
 {
-	struct drm_device *dev = mgr->dev;
-
 	return to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr->base));
 }
 EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);