| Message ID | 20191013171732.2169010-1-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: dac: vf610: Use devm_platform_ioremap_resource | expand |
On Sun, 2019-10-13 at 18:17 +0100, jic23@kernel.org wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Reduce local boilerplate. > Suggested by coccinelle > > CHECK drivers/iio/dac/vf610_dac.c > drivers/iio/dac/vf610_dac.c:189:1-11: WARNING: Use > devm_platform_ioremap_resource for info -> regs > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Sanchayan Maity <maitysanchayan@gmail.com> > --- > drivers/iio/dac/vf610_dac.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c > index 0ec4d2609ef9..71f8a5c471c4 100644 > --- a/drivers/iio/dac/vf610_dac.c > +++ b/drivers/iio/dac/vf610_dac.c > @@ -172,7 +172,6 @@ static int vf610_dac_probe(struct platform_device > *pdev) > { > struct iio_dev *indio_dev; > struct vf610_dac *info; > - struct resource *mem; > int ret; > > indio_dev = devm_iio_device_alloc(&pdev->dev, > @@ -185,8 +184,7 @@ static int vf610_dac_probe(struct platform_device > *pdev) > info = iio_priv(indio_dev); > info->dev = &pdev->dev; > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - info->regs = devm_ioremap_resource(&pdev->dev, mem); > + info->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(info->regs)) > return PTR_ERR(info->regs); >
On Mon, 4 Nov 2019 15:18:09 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Sun, 2019-10-13 at 18:17 +0100, jic23@kernel.org wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Reduce local boilerplate. > > Suggested by coccinelle > > > > CHECK drivers/iio/dac/vf610_dac.c > > drivers/iio/dac/vf610_dac.c:189:1-11: WARNING: Use > > devm_platform_ioremap_resource for info -> regs > > > > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Applied, Thanks, Jonathan > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Sanchayan Maity <maitysanchayan@gmail.com> > > --- > > drivers/iio/dac/vf610_dac.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c > > index 0ec4d2609ef9..71f8a5c471c4 100644 > > --- a/drivers/iio/dac/vf610_dac.c > > +++ b/drivers/iio/dac/vf610_dac.c > > @@ -172,7 +172,6 @@ static int vf610_dac_probe(struct platform_device > > *pdev) > > { > > struct iio_dev *indio_dev; > > struct vf610_dac *info; > > - struct resource *mem; > > int ret; > > > > indio_dev = devm_iio_device_alloc(&pdev->dev, > > @@ -185,8 +184,7 @@ static int vf610_dac_probe(struct platform_device > > *pdev) > > info = iio_priv(indio_dev); > > info->dev = &pdev->dev; > > > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - info->regs = devm_ioremap_resource(&pdev->dev, mem); > > + info->regs = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(info->regs)) > > return PTR_ERR(info->regs); > >
diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c index 0ec4d2609ef9..71f8a5c471c4 100644 --- a/drivers/iio/dac/vf610_dac.c +++ b/drivers/iio/dac/vf610_dac.c @@ -172,7 +172,6 @@ static int vf610_dac_probe(struct platform_device *pdev) { struct iio_dev *indio_dev; struct vf610_dac *info; - struct resource *mem; int ret; indio_dev = devm_iio_device_alloc(&pdev->dev, @@ -185,8 +184,7 @@ static int vf610_dac_probe(struct platform_device *pdev) info = iio_priv(indio_dev); info->dev = &pdev->dev; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - info->regs = devm_ioremap_resource(&pdev->dev, mem); + info->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(info->regs)) return PTR_ERR(info->regs);