drm/panfrost: Add missing GPU feature registers
diff mbox series

Message ID 20191014151515.13839-1-steven.price@arm.com
State New
Headers show
Series
  • drm/panfrost: Add missing GPU feature registers
Related show

Commit Message

Steven Price Oct. 14, 2019, 3:15 p.m. UTC
Three feature registers were declared but never actually read from the
GPU. Add THREAD_MAX_THREADS, THREAD_MAX_WORKGROUP_SIZE and
THREAD_MAX_BARRIER_SIZE so that the complete set are available.

Fixes: 4bced8bea094 ("drm/panfrost: Export all GPU feature registers")
Signed-off-by: Steven Price <steven.price@arm.com>
---
 drivers/gpu/drm/panfrost/panfrost_gpu.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring Oct. 14, 2019, 7:05 p.m. UTC | #1
On Mon, Oct 14, 2019 at 10:15 AM Steven Price <steven.price@arm.com> wrote:
>
> Three feature registers were declared but never actually read from the
> GPU. Add THREAD_MAX_THREADS, THREAD_MAX_WORKGROUP_SIZE and
> THREAD_MAX_BARRIER_SIZE so that the complete set are available.
>
> Fixes: 4bced8bea094 ("drm/panfrost: Export all GPU feature registers")
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_gpu.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied to drm-misc-fixes.

Rob

Patch
diff mbox series

diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
index f67ed925c0ef..8822ec13a0d6 100644
--- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
@@ -208,6 +208,9 @@  static void panfrost_gpu_init_features(struct panfrost_device *pfdev)
 	pfdev->features.mem_features = gpu_read(pfdev, GPU_MEM_FEATURES);
 	pfdev->features.mmu_features = gpu_read(pfdev, GPU_MMU_FEATURES);
 	pfdev->features.thread_features = gpu_read(pfdev, GPU_THREAD_FEATURES);
+	pfdev->features.max_threads = gpu_read(pfdev, GPU_THREAD_MAX_THREADS);
+	pfdev->features.thread_max_workgroup_sz = gpu_read(pfdev, GPU_THREAD_MAX_WORKGROUP_SIZE);
+	pfdev->features.thread_max_barrier_sz = gpu_read(pfdev, GPU_THREAD_MAX_BARRIER_SIZE);
 	pfdev->features.coherency_features = gpu_read(pfdev, GPU_COHERENCY_FEATURES);
 	for (i = 0; i < 4; i++)
 		pfdev->features.texture_features[i] = gpu_read(pfdev, GPU_TEXTURE_FEATURES(i));