| Message ID | 20191014172145.9669-1-jsnitsel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | efi/tpm: return -EINVAL when determining tpm final events log size fails | expand |
On Mon, Oct 14, 2019 at 10:21:45AM -0700, Jerry Snitselaar wrote: > Currently nothing checks the return value of efi_tpm_eventlog_init, > but in case that changes in the future make sure an error is > returned when it fails to determine the tpm final events log > size. > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Cc: linux-efi@vger.kernel.org > Cc: linux-integrity@vger.kernel.org > Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing") > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko
diff --git a/drivers/firmware/efi/tpm.c b/drivers/firmware/efi/tpm.c index ebd7977653a8..31f9f0e369b9 100644 --- a/drivers/firmware/efi/tpm.c +++ b/drivers/firmware/efi/tpm.c @@ -88,6 +88,7 @@ int __init efi_tpm_eventlog_init(void) if (tbl_size < 0) { pr_err(FW_BUG "Failed to parse event in TPM Final Events Log\n"); + ret = -EINVAL; goto out_calc; }
Currently nothing checks the return value of efi_tpm_eventlog_init, but in case that changes in the future make sure an error is returned when it fails to determine the tpm final events log size. Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Cc: linux-efi@vger.kernel.org Cc: linux-integrity@vger.kernel.org Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing") Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com> --- drivers/firmware/efi/tpm.c | 1 + 1 file changed, 1 insertion(+)