diff mbox series

[1/1] gitk: Preserve window dimensions on exit when not using ttk themes

Message ID 364976a833e33696e983bbdd9c1e7974480c1397.1571098396.git.gitgitgadget@gmail.com (mailing list archive)
State New, archived
Headers show
Series gitk: Preserve window dimensions on exit when not using ttk themes | expand

Commit Message

Koji Nakamaru via GitGitGadget Oct. 15, 2019, 12:13 a.m. UTC 
From: Eric Huber <echuber2@illinois.edu>

Bug was: gitk would overwrite the botwidth setting in .gitk with
a nonsense value when not using tk themes. I'm not sure if this
is the right fix or not but it seems to work. Moving the affected
line within the conditional results in the expected behavior.

Signed-off-by: Eric Huber <echuber2@illinois.edu>
---
 gitk-git/gitk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paul Mackerras Dec. 15, 2019, 5:33 a.m. UTC | #1 
On Tue, Oct 15, 2019 at 12:13:16AM +0000, Eric Huber via GitGitGadget wrote:
> From: Eric Huber <echuber2@illinois.edu>
> 
> Bug was: gitk would overwrite the botwidth setting in .gitk with
> a nonsense value when not using tk themes. I'm not sure if this
> is the right fix or not but it seems to work. Moving the affected
> line within the conditional results in the expected behavior.
> 
> Signed-off-by: Eric Huber <echuber2@illinois.edu>

Thanks, patch applied.

Paul.
diff mbox series

Patch

diff --git a/gitk-git/gitk b/gitk-git/gitk
index abe4805ade..4846f2a983 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2526,9 +2526,9 @@  proc makewindow {} {
             bind %W <Map> {}
             %W sashpos 0 $::geometry(botwidth)
         }
+	bind .pwbottom <Configure> {resizecdetpanes %W %w}
     }
-
-    bind .pwbottom <Configure> {resizecdetpanes %W %w}
+    
     pack .ctop -fill both -expand 1
     bindall <1> {selcanvline %W %x %y}
     #bindall <B1-Motion> {selcanvline %W %x %y}