[v2] ASoC: pcm3168a: Fix serial mode dependent format support
diff mbox series

Message ID 20191015090037.23271-1-peter.ujfalusi@ti.com
State Accepted
Commit a35716a95655d8fc15042c9d574374eceb9daf3d
Headers show
Series
  • [v2] ASoC: pcm3168a: Fix serial mode dependent format support
Related show

Commit Message

Peter Ujfalusi Oct. 15, 2019, 9 a.m. UTC
fmt 0 is perfectly valid (PCM3168A_FMT_I2S). Remove the return in case
fmt == 0.

Fixes: ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats")
Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi,

Changes since v1:
- Remove one extra blank line also

Regards,
Peter

 sound/soc/codecs/pcm3168a.c | 3 ---
 1 file changed, 3 deletions(-)

Patch
diff mbox series

diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c
index 708dac27feff..313500ab36df 100644
--- a/sound/soc/codecs/pcm3168a.c
+++ b/sound/soc/codecs/pcm3168a.c
@@ -322,9 +322,6 @@  static void pcm3168a_update_fixup_pcm_stream(struct snd_soc_dai *dai)
 	u64 formats = SNDRV_PCM_FMTBIT_S24_3LE | SNDRV_PCM_FMTBIT_S24_LE;
 	unsigned int channel_max = dai->id == PCM3168A_DAI_DAC ? 8 : 6;
 
-	if (!pcm3168a->io_params[dai->id].fmt)
-		return;
-
 	if (pcm3168a->io_params[dai->id].fmt == PCM3168A_FMT_RIGHT_J) {
 		/* S16_LE is only supported in RIGHT_J mode */
 		formats |= SNDRV_PCM_FMTBIT_S16_LE;