drm/komeda: Dump SC_ENH_* registers from scaler block
diff mbox series

Message ID 20191015105936.50039-1-mihail.atanassov@arm.com
State New
Headers show
Series
  • drm/komeda: Dump SC_ENH_* registers from scaler block
Related show

Commit Message

Mihail Atanassov Oct. 15, 2019, 11 a.m. UTC
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
 .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Comments

james qian wang (Arm Technology China) Oct. 16, 2019, 8:17 a.m. UTC | #1
On Tue, Oct 15, 2019 at 11:00:01AM +0000, Mihail Atanassov wrote:
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
>  .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> index c3d29c0b051b..7252fc387fba 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> @@ -703,7 +703,7 @@ static void d71_scaler_update(struct komeda_component *c,
>  
>  static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
>  {
> -	u32 v[9];
> +	u32 v[10];
>  
>  	dump_block_header(sf, c->reg);
>  
> @@ -723,6 +723,18 @@ static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
>  	seq_printf(sf, "SC_H_DELTA_PH:\t\t0x%X\n", v[6]);
>  	seq_printf(sf, "SC_V_INIT_PH:\t\t0x%X\n", v[7]);
>  	seq_printf(sf, "SC_V_DELTA_PH:\t\t0x%X\n", v[8]);
> +
> +	get_values_from_reg(c->reg, 0x130, 10, v);
> +	seq_printf(sf, "SC_ENH_LIMITS:\t\t0x%X\n", v[0]);
> +	seq_printf(sf, "SC_ENH_COEFF0:\t\t0x%X\n", v[1]);
> +	seq_printf(sf, "SC_ENH_COEFF1:\t\t0x%X\n", v[2]);
> +	seq_printf(sf, "SC_ENH_COEFF2:\t\t0x%X\n", v[3]);
> +	seq_printf(sf, "SC_ENH_COEFF3:\t\t0x%X\n", v[4]);
> +	seq_printf(sf, "SC_ENH_COEFF4:\t\t0x%X\n", v[5]);
> +	seq_printf(sf, "SC_ENH_COEFF5:\t\t0x%X\n", v[6]);
> +	seq_printf(sf, "SC_ENH_COEFF6:\t\t0x%X\n", v[7]);
> +	seq_printf(sf, "SC_ENH_COEFF7:\t\t0x%X\n", v[8]);
> +	seq_printf(sf, "SC_ENH_COEFF8:\t\t0x%X\n", v[9]);
>  }
>

Looks good to me.

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>

>  static const struct komeda_component_funcs d71_scaler_funcs = {
Mihail Atanassov Oct. 21, 2019, 1:42 p.m. UTC | #2
On Wednesday, 16 October 2019 09:17:39 BST james qian wang (Arm Technology China) wrote:
> On Tue, Oct 15, 2019 at 11:00:01AM +0000, Mihail Atanassov wrote:
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> >  .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +++++++++++++-
> >  1 file changed, 13 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > index c3d29c0b051b..7252fc387fba 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > @@ -703,7 +703,7 @@ static void d71_scaler_update(struct komeda_component *c,
> >  
> >  static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
> >  {
> > -	u32 v[9];
> > +	u32 v[10];
> >  
> >  	dump_block_header(sf, c->reg);
> >  
> > @@ -723,6 +723,18 @@ static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
> >  	seq_printf(sf, "SC_H_DELTA_PH:\t\t0x%X\n", v[6]);
> >  	seq_printf(sf, "SC_V_INIT_PH:\t\t0x%X\n", v[7]);
> >  	seq_printf(sf, "SC_V_DELTA_PH:\t\t0x%X\n", v[8]);
> > +
> > +	get_values_from_reg(c->reg, 0x130, 10, v);
> > +	seq_printf(sf, "SC_ENH_LIMITS:\t\t0x%X\n", v[0]);
> > +	seq_printf(sf, "SC_ENH_COEFF0:\t\t0x%X\n", v[1]);
> > +	seq_printf(sf, "SC_ENH_COEFF1:\t\t0x%X\n", v[2]);
> > +	seq_printf(sf, "SC_ENH_COEFF2:\t\t0x%X\n", v[3]);
> > +	seq_printf(sf, "SC_ENH_COEFF3:\t\t0x%X\n", v[4]);
> > +	seq_printf(sf, "SC_ENH_COEFF4:\t\t0x%X\n", v[5]);
> > +	seq_printf(sf, "SC_ENH_COEFF5:\t\t0x%X\n", v[6]);
> > +	seq_printf(sf, "SC_ENH_COEFF6:\t\t0x%X\n", v[7]);
> > +	seq_printf(sf, "SC_ENH_COEFF7:\t\t0x%X\n", v[8]);
> > +	seq_printf(sf, "SC_ENH_COEFF8:\t\t0x%X\n", v[9]);
> >  }
> >
> 
> Looks good to me.
> 
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>

Thanks, applied to drm-misc-next - 
2b6f5883edcc47ef6146832112a0125810d28f78.

> 
> >  static const struct komeda_component_funcs d71_scaler_funcs = {
>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
index c3d29c0b051b..7252fc387fba 100644
--- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
+++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
@@ -703,7 +703,7 @@  static void d71_scaler_update(struct komeda_component *c,
 
 static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
 {
-	u32 v[9];
+	u32 v[10];
 
 	dump_block_header(sf, c->reg);
 
@@ -723,6 +723,18 @@  static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
 	seq_printf(sf, "SC_H_DELTA_PH:\t\t0x%X\n", v[6]);
 	seq_printf(sf, "SC_V_INIT_PH:\t\t0x%X\n", v[7]);
 	seq_printf(sf, "SC_V_DELTA_PH:\t\t0x%X\n", v[8]);
+
+	get_values_from_reg(c->reg, 0x130, 10, v);
+	seq_printf(sf, "SC_ENH_LIMITS:\t\t0x%X\n", v[0]);
+	seq_printf(sf, "SC_ENH_COEFF0:\t\t0x%X\n", v[1]);
+	seq_printf(sf, "SC_ENH_COEFF1:\t\t0x%X\n", v[2]);
+	seq_printf(sf, "SC_ENH_COEFF2:\t\t0x%X\n", v[3]);
+	seq_printf(sf, "SC_ENH_COEFF3:\t\t0x%X\n", v[4]);
+	seq_printf(sf, "SC_ENH_COEFF4:\t\t0x%X\n", v[5]);
+	seq_printf(sf, "SC_ENH_COEFF5:\t\t0x%X\n", v[6]);
+	seq_printf(sf, "SC_ENH_COEFF6:\t\t0x%X\n", v[7]);
+	seq_printf(sf, "SC_ENH_COEFF7:\t\t0x%X\n", v[8]);
+	seq_printf(sf, "SC_ENH_COEFF8:\t\t0x%X\n", v[9]);
 }
 
 static const struct komeda_component_funcs d71_scaler_funcs = {