[7/8] btrfs: Rename find_oldest_super_backup to init_backup_root_slot
diff mbox series

Message ID 20191015154224.21537-8-nborisov@suse.com
State New
Headers show
  • tree reading cleanups in mount
Related show

Commit Message

Nikolay Borisov Oct. 15, 2019, 3:42 p.m. UTC
The old name name was an awful misnomer because it didn't really find
the oldest super backup per se but rather its slot. For example if we

slot0: gen - 2
slot1: gen - 1
slot2: gen
slot3: empty

init_backup_root_slot will return slot3 and not slot0.

The new name is more appropriate since the function doesn't care whether
there is a valid backup in the returned slot or not.
 fs/btrfs/disk-io.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff mbox series

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index bcb21a35d30c..ac899fdb1414 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -1786,13 +1786,11 @@  static int find_newest_super_backup(struct btrfs_fs_info *info)
 	return -EINVAL;
- * find the oldest backup so we know where to store new entries
- * in the backup array.  This will set the backup_root_index
- * field in the fs_info struct
+ * Initialize backup_root_index with the next available slot, where subsequent
+ * transaction commit will store the back up root
-static void find_oldest_super_backup(struct btrfs_fs_info *info)
+static void init_backup_root_slot(struct btrfs_fs_info *info)
 	int newest_index;
@@ -2904,7 +2902,7 @@  int __cold open_ctree(struct super_block *sb,
 	 * run through our array of backup supers and setup
 	 * our ring pointer to the oldest one
-	find_oldest_super_backup(fs_info);
+	init_backup_root_slot(fs_info);
 	 * In the long term, we'll store the compression type in the super