| Message ID | 20191015173026.9962-2-manivannan.sadhasivam@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add GPIO support for RDA8810PL SoC | expand |
On Tue, Oct 15, 2019 at 7:30 PM Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > Add YAML devicetree binding for RDA Micro GPIO controller. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> First: this looks awesome to me, Second: since this is kind of a first... could we move the standard GPIOchip YAML business into a generic gpiochip .yaml file? We currently only have pl061-gpio.yaml and this would duplicate a lot of the stuff from that yaml file. If you look at how display/panel/panel-common.yaml is used from say display/panel/ti,nspire.yaml Could we do something similar and lift out all the generics from gpio-pl061.yaml to gpio-common.yaml and reference that also in the new binding? If it seems hard, tell me and I can take a stab at it. Yours, Linus Walleij
Hi Linus, On Wed, Oct 16, 2019 at 02:27:44PM +0200, Linus Walleij wrote: > On Tue, Oct 15, 2019 at 7:30 PM Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> wrote: > > > Add YAML devicetree binding for RDA Micro GPIO controller. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > First: this looks awesome to me, > > Second: since this is kind of a first... could we move the standard GPIOchip > YAML business into a generic gpiochip .yaml file? > > We currently only have pl061-gpio.yaml and this would duplicate a lot > of the stuff from that yaml file. > > If you look at how > display/panel/panel-common.yaml > is used from say > display/panel/ti,nspire.yaml > > Could we do something similar and lift out all the generics from > gpio-pl061.yaml to > gpio-common.yaml > and reference that also in the new binding? > > If it seems hard, tell me and I can take a stab at it. > Eventhough I really want to help you here, I'm running out of time (and you know why). Let's consider merging this, and I'll come back at it later. Thanks, Mani > Yours, > Linus Walleij
diff --git a/Documentation/devicetree/bindings/gpio/gpio-rda.yaml b/Documentation/devicetree/bindings/gpio/gpio-rda.yaml new file mode 100644 index 000000000000..6ece555f074f --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/gpio-rda.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/gpio-rda.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: RDA Micro GPIO controller + +maintainers: + - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> + +properties: + compatible: + const: rda,8810pl-gpio + + reg: + maxItems: 1 + + gpio-controller: true + + "#gpio-cells": + const: 2 + + ngpios: + description: + Number of available gpios in a bank. + minimum: 1 + maximum: 32 + + interrupt-controller: true + + "#interrupt-cells": + const: 2 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - gpio-controller + - "#gpio-cells" + - ngpios + - interrupt-controller + - "#interrupt-cells" + - interrupts + +additionalProperties: false + +...
Add YAML devicetree binding for RDA Micro GPIO controller. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- .../devicetree/bindings/gpio/gpio-rda.yaml | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/gpio-rda.yaml