[-next,03/13] hwrng: exynos - use devm_platform_ioremap_resource() to simplify code
diff mbox series

Message ID 20191016104621.26056-4-yuehaibing@huawei.com
State New
Headers show
Series
  • hwrng: use devm_platform_ioremap_resource() to simplify code
Related show

Commit Message

Yuehaibing Oct. 16, 2019, 10:46 a.m. UTC
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/char/hw_random/exynos-trng.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Łukasz Stelmach Oct. 18, 2019, 3:05 p.m. UTC | #1
It was <2019-10-16 śro 12:46>, when YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/char/hw_random/exynos-trng.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>

Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>

> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c
> index b4b52ab..8e1fe3f 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -109,7 +109,6 @@ static int exynos_trng_init(struct hwrng *rng)
>  static int exynos_trng_probe(struct platform_device *pdev)
>  {
>  	struct exynos_trng_dev *trng;
> -	struct resource *res;
>  	int ret = -ENOMEM;
>  
>  	trng = devm_kzalloc(&pdev->dev, sizeof(*trng), GFP_KERNEL);
> @@ -128,8 +127,7 @@ static int exynos_trng_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, trng);
>  	trng->dev = &pdev->dev;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	trng->mem = devm_ioremap_resource(&pdev->dev, res);
> +	trng->mem = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(trng->mem))
>  		return PTR_ERR(trng->mem);

Patch
diff mbox series

diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c
index b4b52ab..8e1fe3f 100644
--- a/drivers/char/hw_random/exynos-trng.c
+++ b/drivers/char/hw_random/exynos-trng.c
@@ -109,7 +109,6 @@  static int exynos_trng_init(struct hwrng *rng)
 static int exynos_trng_probe(struct platform_device *pdev)
 {
 	struct exynos_trng_dev *trng;
-	struct resource *res;
 	int ret = -ENOMEM;
 
 	trng = devm_kzalloc(&pdev->dev, sizeof(*trng), GFP_KERNEL);
@@ -128,8 +127,7 @@  static int exynos_trng_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, trng);
 	trng->dev = &pdev->dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	trng->mem = devm_ioremap_resource(&pdev->dev, res);
+	trng->mem = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(trng->mem))
 		return PTR_ERR(trng->mem);