ASoC: dt-bindings: rt1011: add r0 and temperature device property
diff mbox series

Message ID 20191016115617.23213-1-shumingf@realtek.com
State Accepted
Commit cf775f68a0939f0e5aad5855f63338c4b5e51c59
Headers show
Series
  • ASoC: dt-bindings: rt1011: add r0 and temperature device property
Related show

Commit Message

Shuming [θŒƒζ›ΈιŠ˜] Oct. 16, 2019, 11:56 a.m. UTC
From: Shuming Fan <shumingf@realtek.com>

Typically, the r0 (calibration data) and temperature were measured in the factory.
This information is written into the non-volatile area
where keeps data whether factory reset or OS update.

Signed-off-by: Shuming Fan <shumingf@realtek.com>
---
 Documentation/devicetree/bindings/sound/rt1011.txt | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Mark Brown Oct. 16, 2019, 12:54 p.m. UTC | #1
On Wed, Oct 16, 2019 at 07:56:17PM +0800, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
> 
> Typically, the r0 (calibration data) and temperature were measured in the factory.
> This information is written into the non-volatile area
> where keeps data whether factory reset or OS update.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
Mark Brown Oct. 16, 2019, 12:57 p.m. UTC | #2
On Wed, Oct 16, 2019 at 01:54:49PM +0100, Mark Brown wrote:
> On Wed, Oct 16, 2019 at 07:56:17PM +0800, shumingf@realtek.com wrote:

> > Typically, the r0 (calibration data) and temperature were measured in the factory.
> > This information is written into the non-volatile area
> > where keeps data whether factory reset or OS update.

> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

Sorry, fat fingered things and replied to the wrong e-mail here - no
issues at all with the subject line on this one.

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/sound/rt1011.txt b/Documentation/devicetree/bindings/sound/rt1011.txt
index 35a23e60d679..02d53b9aa247 100644
--- a/Documentation/devicetree/bindings/sound/rt1011.txt
+++ b/Documentation/devicetree/bindings/sound/rt1011.txt
@@ -20,6 +20,14 @@  Required properties:
         |     1     |    1     |   0x3b     |
         -------------------------------------
 
+Optional properties:
+
+- realtek,temperature_calib
+  u32. The temperature was measured while doing the calibration. Units: Celsius degree
+
+- realtek,r0_calib
+  u32. This is r0 calibration data which was measured in factory mode.
+
 Pins on the device (for linking into audio routes) for RT1011:
 
   * SPO
@@ -29,4 +37,6 @@  Example:
 rt1011: codec@38 {
 	compatible = "realtek,rt1011";
 	reg = <0x38>;
+	realtek,temperature_calib = <25>;
+	realtek,r0_calib = <0x224050>;
 };