| Message ID | 20191016192430.25098-6-ehabkost@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | image-fuzzer: Port to Python 3 | expand |
"fields" in the commit message. On 10/16/19 3:24 PM, Eduardo Habkost wrote: > This makes the formatting code simpler, and safer if we change > the type of self.value from str to bytes. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > tests/image-fuzzer/qcow2/layout.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/image-fuzzer/qcow2/layout.py b/tests/image-fuzzer/qcow2/layout.py > index 6501c9fd4b..0adcbd448d 100644 > --- a/tests/image-fuzzer/qcow2/layout.py > +++ b/tests/image-fuzzer/qcow2/layout.py > @@ -53,8 +53,8 @@ class Field(object): > return iter([self.fmt, self.offset, self.value, self.name]) > > def __repr__(self): > - return "Field(fmt='%s', offset=%d, value=%s, name=%s)" % \ > - (self.fmt, self.offset, str(self.value), self.name) > + return "Field(fmt=%r, offset=%r, value=%r, name=%r)" % \ > + (self.fmt, self.offset, self.value, self.name) > > > class FieldsList(object): >
diff --git a/tests/image-fuzzer/qcow2/layout.py b/tests/image-fuzzer/qcow2/layout.py index 6501c9fd4b..0adcbd448d 100644 --- a/tests/image-fuzzer/qcow2/layout.py +++ b/tests/image-fuzzer/qcow2/layout.py @@ -53,8 +53,8 @@ class Field(object): return iter([self.fmt, self.offset, self.value, self.name]) def __repr__(self): - return "Field(fmt='%s', offset=%d, value=%s, name=%s)" % \ - (self.fmt, self.offset, str(self.value), self.name) + return "Field(fmt=%r, offset=%r, value=%r, name=%r)" % \ + (self.fmt, self.offset, self.value, self.name) class FieldsList(object):
This makes the formatting code simpler, and safer if we change the type of self.value from str to bytes. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- tests/image-fuzzer/qcow2/layout.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)