| Message ID | 20191017144841.GA16393@chrisdown.name (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 66d0a3b57bbe0083080682fe74236174f3cadad7 |
| Delegated to: | Luca Coelho |
| Headers | show |
| Series | iwlwifi: Don't IWL_WARN on FW reconfiguration | expand |
To be more clear in case this actually is representative of a real problem
(although I doubt it since this seems present on every device like this I
encountered), it's always FW_DBG_START_FROM_ALIVE:
% sudo journalctl _TRANSPORT=kernel -o cat | grep 'FW already configured' | sort | uniq -c
403 iwlwifi 0000:3a:00.0: FW already configured (0) - re-configuring
Just to check in again since this is still happening: is this expected? I expect that if this is IWL_WARN, it should indicate some unexpected or non-ideal state, but the card seems to operate just fine afterwards.
On 2020 Jul 13, Chris Down wrote: > Just to check in again since this is still happening: is this expected? > > I expect that if this is IWL_WARN, it should indicate some unexpected or > non-ideal state, but the card seems to operate just fine afterwards. I'm confused too, cause I'm seeing this on an AC 8260 now, whereas in the past there wasn't such a message. Is this something the user should be aware of? If not, I'm with Chris that this should be silenced.
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index 5c8602de9168..ac7ecb76d964 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c @@ -2264,7 +2264,7 @@ int iwl_fw_start_dbg_conf(struct iwl_fw_runtime *fwrt, u8 conf_id) return -EINVAL; if (fwrt->dump.conf != FW_DBG_INVALID) - IWL_WARN(fwrt, "FW already configured (%d) - re-configuring\n", + IWL_INFO(fwrt, "FW already configured (%d) - re-configuring\n", fwrt->dump.conf); /* Send all HCMDs for configuring the FW debug */
IWL_WARN seems excessive here since this can happen during normal operation. Every time I connect to a new network with 8086:24fd I get this as KERN_WARNING on the console, which mildly distracts from other more pressing messages. For example: % sudo journalctl _TRANSPORT=kernel | grep -c 'FW already configured' 403 Signed-off-by: Chris Down <chris@chrisdown.name> Cc: Shahar S Matityahu <shahar.s.matityahu@intel.com> Cc: Luca Coelho <luciano.coelho@intel.com> Cc: linux-kernel@vger.kernel.org Cc: linux-wireless@vger.kernel.org --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)