| Message ID | 20191017175624.30305-15-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/14] iomap: iomap that extends beyond EOF should be marked dirty | expand |
On Thu, Oct 17, 2019 at 07:56:24PM +0200, Christoph Hellwig wrote: > No need to pass the full bio_vec. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > fs/iomap/buffered-io.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index bb96499c352f..755b75424a97 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -1110,13 +1110,13 @@ vm_fault_t iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops) > EXPORT_SYMBOL_GPL(iomap_page_mkwrite); > > static void > -iomap_finish_page_writeback(struct inode *inode, struct bio_vec *bvec, > +iomap_finish_page_writeback(struct inode *inode, struct page *page, > int error) > { > - struct iomap_page *iop = to_iomap_page(bvec->bv_page); > + struct iomap_page *iop = to_iomap_page(page); > > if (error) { > - SetPageError(bvec->bv_page); > + SetPageError(page); > mapping_set_error(inode->i_mapping, -EIO); > } > > @@ -1124,7 +1124,7 @@ iomap_finish_page_writeback(struct inode *inode, struct bio_vec *bvec, > WARN_ON_ONCE(iop && atomic_read(&iop->write_count) <= 0); > > if (!iop || atomic_dec_and_test(&iop->write_count)) > - end_page_writeback(bvec->bv_page); > + end_page_writeback(page); > } > > /* > @@ -1156,7 +1156,7 @@ iomap_finish_ioend(struct iomap_ioend *ioend, int error) > > /* walk each page on bio, ending page IO on them */ > bio_for_each_segment_all(bv, bio, iter_all) > - iomap_finish_page_writeback(inode, bv, error); > + iomap_finish_page_writeback(inode, bv->bv_page, error); > bio_put(bio); > } > > -- > 2.20.1 >
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index bb96499c352f..755b75424a97 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -1110,13 +1110,13 @@ vm_fault_t iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops) EXPORT_SYMBOL_GPL(iomap_page_mkwrite); static void -iomap_finish_page_writeback(struct inode *inode, struct bio_vec *bvec, +iomap_finish_page_writeback(struct inode *inode, struct page *page, int error) { - struct iomap_page *iop = to_iomap_page(bvec->bv_page); + struct iomap_page *iop = to_iomap_page(page); if (error) { - SetPageError(bvec->bv_page); + SetPageError(page); mapping_set_error(inode->i_mapping, -EIO); } @@ -1124,7 +1124,7 @@ iomap_finish_page_writeback(struct inode *inode, struct bio_vec *bvec, WARN_ON_ONCE(iop && atomic_read(&iop->write_count) <= 0); if (!iop || atomic_dec_and_test(&iop->write_count)) - end_page_writeback(bvec->bv_page); + end_page_writeback(page); } /* @@ -1156,7 +1156,7 @@ iomap_finish_ioend(struct iomap_ioend *ioend, int error) /* walk each page on bio, ending page IO on them */ bio_for_each_segment_all(bv, bio, iter_all) - iomap_finish_page_writeback(inode, bv, error); + iomap_finish_page_writeback(inode, bv->bv_page, error); bio_put(bio); }
No need to pass the full bio_vec. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/iomap/buffered-io.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)