[-next] btrfs: Make init_tree_roots static
diff mbox series

Message ID 20191018120604.29508-1-yuehaibing@huawei.com
State New
Headers show
Series
  • [-next] btrfs: Make init_tree_roots static
Related show

Commit Message

Yuehaibing Oct. 18, 2019, 12:06 p.m. UTC
Fix sparse warning:

fs/btrfs/disk-io.c:2534:12: warning:
 symbol 'init_tree_roots' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 fs/btrfs/disk-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nikolay Borisov Oct. 18, 2019, 12:09 p.m. UTC | #1
On 18.10.19 г. 15:06 ч., YueHaibing wrote:
> Fix sparse warning:
> 
> fs/btrfs/disk-io.c:2534:12: warning:
>  symbol 'init_tree_roots' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Huhz, I thought I had added static... Anyway this could be folded in the
original patch. Thanks for the report.

> ---
>  fs/btrfs/disk-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index d078276..cb187f5 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -2531,7 +2531,7 @@ static int btrfs_validate_write_super(struct btrfs_fs_info *fs_info,
>  	return ret;
>  }
>  
> -int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
> +static int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
>  {
>  	int backup_index = find_newest_super_backup(fs_info);
>  	struct btrfs_super_block *sb = fs_info->super_copy;
>
David Sterba Oct. 21, 2019, 1:17 p.m. UTC | #2
On Fri, Oct 18, 2019 at 03:09:58PM +0300, Nikolay Borisov wrote:
> 
> 
> On 18.10.19 г. 15:06 ч., YueHaibing wrote:
> > Fix sparse warning:
> > 
> > fs/btrfs/disk-io.c:2534:12: warning:
> >  symbol 'init_tree_roots' was not declared. Should it be static?
> > 
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> Huhz, I thought I had added static... Anyway this could be folded in the
> original patch. Thanks for the report.

Folded.

Patch
diff mbox series

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index d078276..cb187f5 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2531,7 +2531,7 @@  static int btrfs_validate_write_super(struct btrfs_fs_info *fs_info,
 	return ret;
 }
 
-int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
+static int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
 {
 	int backup_index = find_newest_super_backup(fs_info);
 	struct btrfs_super_block *sb = fs_info->super_copy;