[1/2] dt-bindings: arm: at91: Document SmartKiz board binding
diff mbox series

Message ID 20191018140658.31703-2-kamel.bouhara@bootlin.com
State New
Headers show
Series
  • Add DTS for Smartkiz support
Related show

Commit Message

Kamel Bouhara Oct. 18, 2019, 2:06 p.m. UTC
Document devicetree's bindings for the SAM9G25 SmartKiz board of
Overkiz SAS.

Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
---
 Documentation/devicetree/bindings/arm/atmel-at91.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Rob Herring Oct. 29, 2019, 12:38 p.m. UTC | #1
On Fri, Oct 18, 2019 at 04:06:57PM +0200, Kamel Bouhara wrote:
> Document devicetree's bindings for the SAM9G25 SmartKiz board of
> Overkiz SAS.
> 
> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> ---
>  Documentation/devicetree/bindings/arm/atmel-at91.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index 666462988179..f8053268cfa5 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -49,8 +49,16 @@ properties:
>            - const: atmel,at91sam9x5
>            - const: atmel,at91sam9
>  
> +      - description: Overkiz SmartKiz Board
> +        items:
> +          - const: overkiz,smartkiz
> +          - const: atmel,at91sam9g25
> +          - const: atmel,at91sam9x5
> +          - const: atmel,at91sam9
> +
>        - items:
>            - enum:
> +              - atmel,at91sam9g25
>                - atmel,at91sam9g15
>                - atmel,at91sam9g25

Duplicated... You did check this with 'make dt_binding_check', right?

>                - atmel,at91sam9g35
> -- 
> 2.23.0
>
Kamel Bouhara Nov. 6, 2019, 8:34 a.m. UTC | #2
On 29/10/2019 13:38, Rob Herring wrote:
> On Fri, Oct 18, 2019 at 04:06:57PM +0200, Kamel Bouhara wrote:
>> Document devicetree's bindings for the SAM9G25 SmartKiz board of
>> Overkiz SAS.
>>
>> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
>> ---
>>   Documentation/devicetree/bindings/arm/atmel-at91.yaml | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> index 666462988179..f8053268cfa5 100644
>> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> @@ -49,8 +49,16 @@ properties:
>>             - const: atmel,at91sam9x5
>>             - const: atmel,at91sam9
>>   
>> +      - description: Overkiz SmartKiz Board
>> +        items:
>> +          - const: overkiz,smartkiz
>> +          - const: atmel,at91sam9g25
>> +          - const: atmel,at91sam9x5
>> +          - const: atmel,at91sam9
>> +
>>         - items:
>>             - enum:
>> +              - atmel,at91sam9g25
>>                 - atmel,at91sam9g15
>>                 - atmel,at91sam9g25
> 
> Duplicated... You did check this with 'make dt_binding_check', right?
> 
>>                 - atmel,at91sam9g35

Fixed in v3.

Thanks.
>> -- 
>> 2.23.0
>>
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
index 666462988179..f8053268cfa5 100644
--- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
+++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
@@ -49,8 +49,16 @@  properties:
           - const: atmel,at91sam9x5
           - const: atmel,at91sam9
 
+      - description: Overkiz SmartKiz Board
+        items:
+          - const: overkiz,smartkiz
+          - const: atmel,at91sam9g25
+          - const: atmel,at91sam9x5
+          - const: atmel,at91sam9
+
       - items:
           - enum:
+              - atmel,at91sam9g25
               - atmel,at91sam9g15
               - atmel,at91sam9g25
               - atmel,at91sam9g35