From patchwork Fri Oct 18 14:17:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georgi Djakov X-Patchwork-Id: 11198581 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6C30C1951 for ; Fri, 18 Oct 2019 14:17:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C86B222C3 for ; Fri, 18 Oct 2019 14:17:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R67W02Lz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408437AbfJROR4 (ORCPT ); Fri, 18 Oct 2019 10:17:56 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40320 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392990AbfJRORz (ORCPT ); Fri, 18 Oct 2019 10:17:55 -0400 Received: by mail-wr1-f66.google.com with SMTP id o28so6465416wro.7 for ; Fri, 18 Oct 2019 07:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fTm5JH2L5agfNTgSt6jIVduSEI+HxSv62N1+6WMd74s=; b=R67W02Lz1HjMvW2zQm++LCIQ21AzasDaKd9lyBCAv1JTy32UMXliPR+K+neuS3KxxR IUeID/8BP/H7qC61bBPYfLeuuDOgQW5c0Zy1VjzZOg8ma8zsEgdQWKWyDTgPXxEFuMo/ u89cpWHzeoHBCkfqK4kNCh7bWGZbVn6bQXYwsCT9Pe1VLMF1poeq9qEDdVppr9uRBiQ9 SI5F/BQTW2j+V2QP4q/fnGgWM+dHfAoG1MErow6uLKvK35S134x5sL0grP0Jr9pBta62 uxcOEkzrKXdQMiimnSkNOCeiq8CyB0i+YwhoP+ex01NdUEh4koGBpt/zSeavD5Bqv7ps kSZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fTm5JH2L5agfNTgSt6jIVduSEI+HxSv62N1+6WMd74s=; b=YsYjlEQ+liM51p34Uw2yFx4BO2jK4MqLF1tNArQ9WdqE5do9FW5Awzk5vi8uEuDuEQ T5jgtgTX5kigt+GFrTf/tK96pyDnZqa9b2linoZCQ2lZqYZ34nfhLxk5EPMiiri8QDII XpU4Ok2R9Z2A5X0jHE3N0PsmHNwfTgvQ6aWq4r3MDjDpDJUXenfrKQyQV9Fd4kFNZ5Vk DQw/MZDUeM6UV7dEvkSjayUCSDnUShNhL/5zxfrjHecxgA1MaCOlmAIa21Z96J2wAr0+ Xc4pJ5kGvq5ZCxgAUrCtTOken+iVq5CekQtBj7Ty0omNS8NuM+Hzk/h+aDCfbaoYYYtw KrEw== X-Gm-Message-State: APjAAAUhtQWVAZyXCys1z1B199sMWPWRSxebWD75SBQ4o17oXyu/ftkk UkUb9d+b8BhE5BlVSb2v0C0q4W4LHGmA5w== X-Google-Smtp-Source: APXvYqyXvXy8m4FlfE3Ivxs8/mhlAHKkQr/uz8IZ5NCsVUpgWET0v8kN7+RJAAD51s81jOaWspyCQg== X-Received: by 2002:a5d:490e:: with SMTP id x14mr8607219wrq.340.1571408272158; Fri, 18 Oct 2019 07:17:52 -0700 (PDT) Received: from localhost.localdomain ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id r13sm7110988wra.74.2019.10.18.07.17.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 18 Oct 2019 07:17:51 -0700 (PDT) From: Georgi Djakov To: linux-pm@vger.kernel.org, evgreen@chromium.org, daidavid1@codeaurora.org Cc: vincent.guittot@linaro.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Georgi Djakov Subject: [PATCH] interconnect: Add locking in icc_set_tag() Date: Fri, 18 Oct 2019 17:17:50 +0300 Message-Id: <20191018141750.17032-1-georgi.djakov@linaro.org> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org We must ensure that the tag is not changed while we aggregate the requests. Currently the icc_set_tag() is not using any locks and this may cause the values to be aggregated incorrectly. Fix this by acquiring the icc_lock while we set the tag. Fixes: 127ab2cc5f19 ("interconnect: Add support for path tags") Signed-off-by: Georgi Djakov Reviewed-by: Bjorn Andersson --- drivers/interconnect/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c index e24092558c29..4940c0741d40 100644 --- a/drivers/interconnect/core.c +++ b/drivers/interconnect/core.c @@ -408,8 +408,12 @@ void icc_set_tag(struct icc_path *path, u32 tag) if (!path) return; + mutex_lock(&icc_lock); + for (i = 0; i < path->num_nodes; i++) path->reqs[i].tag = tag; + + mutex_unlock(&icc_lock); } EXPORT_SYMBOL_GPL(icc_set_tag);