| Message ID | 20191019073242.21652-1-wambui@karuga.xyz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/radeon: remove assignment for return value | expand |
On 2019-10-19 3:32 a.m., Wambui Karuga wrote: > Remove unnecessary assignment for return value and have the > function return the required value directly. > Issue found by coccinelle: > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: Wambui Karuga <wambui@karuga.xyz> Thanks for your patch. Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > drivers/gpu/drm/radeon/cik.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c > index 62eab82a64f9..daff9a2af3be 100644 > --- a/drivers/gpu/drm/radeon/cik.c > +++ b/drivers/gpu/drm/radeon/cik.c > @@ -221,9 +221,7 @@ int ci_get_temp(struct radeon_device *rdev) > else > actual_temp = temp & 0x1ff; > > - actual_temp = actual_temp * 1000; > - > - return actual_temp; > + return actual_temp * 1000; > } > > /* get temperature in millidegrees */ > @@ -239,9 +237,7 @@ int kv_get_temp(struct radeon_device *rdev) > else > actual_temp = 0; > > - actual_temp = actual_temp * 1000; > - > - return actual_temp; > + return actual_temp * 1000; > } > > /* >
Applied. Thanks! Alex On Wed, Oct 23, 2019 at 11:09 AM Harry Wentland <hwentlan@amd.com> wrote: > > On 2019-10-19 3:32 a.m., Wambui Karuga wrote: > > Remove unnecessary assignment for return value and have the > > function return the required value directly. > > Issue found by coccinelle: > > @@ > > local idexpression ret; > > expression e; > > @@ > > > > -ret = > > +return > > e; > > -return ret; > > > > Signed-off-by: Wambui Karuga <wambui@karuga.xyz> > > Thanks for your patch. > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > > Harry > > > > --- > > drivers/gpu/drm/radeon/cik.c | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c > > index 62eab82a64f9..daff9a2af3be 100644 > > --- a/drivers/gpu/drm/radeon/cik.c > > +++ b/drivers/gpu/drm/radeon/cik.c > > @@ -221,9 +221,7 @@ int ci_get_temp(struct radeon_device *rdev) > > else > > actual_temp = temp & 0x1ff; > > > > - actual_temp = actual_temp * 1000; > > - > > - return actual_temp; > > + return actual_temp * 1000; > > } > > > > /* get temperature in millidegrees */ > > @@ -239,9 +237,7 @@ int kv_get_temp(struct radeon_device *rdev) > > else > > actual_temp = 0; > > > > - actual_temp = actual_temp * 1000; > > - > > - return actual_temp; > > + return actual_temp * 1000; > > } > > > > /* > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c index 62eab82a64f9..daff9a2af3be 100644 --- a/drivers/gpu/drm/radeon/cik.c +++ b/drivers/gpu/drm/radeon/cik.c @@ -221,9 +221,7 @@ int ci_get_temp(struct radeon_device *rdev) else actual_temp = temp & 0x1ff; - actual_temp = actual_temp * 1000; - - return actual_temp; + return actual_temp * 1000; } /* get temperature in millidegrees */ @@ -239,9 +237,7 @@ int kv_get_temp(struct radeon_device *rdev) else actual_temp = 0; - actual_temp = actual_temp * 1000; - - return actual_temp; + return actual_temp * 1000; } /*
Remove unnecessary assignment for return value and have the function return the required value directly. Issue found by coccinelle: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Wambui Karuga <wambui@karuga.xyz> --- drivers/gpu/drm/radeon/cik.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)