xfs: remove the duplicated inode log fieldmask set
diff mbox series

Message ID 8df3c417-4fb2-f37b-6f27-3df069903c08@gmail.com
State New
Headers show
Series
  • xfs: remove the duplicated inode log fieldmask set
Related show

Commit Message

kaixuxia Oct. 21, 2019, 9:32 a.m. UTC
The xfs_bumplink() call has set the inode log fieldmask XFS_ILOG_CORE,
so the next xfs_trans_log_inode() call is not necessary.

Signed-off-by: kaixuxia <kaixuxia@tencent.com>
---
 fs/xfs/xfs_inode.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Darrick J. Wong Oct. 21, 2019, 3:47 p.m. UTC | #1
On Mon, Oct 21, 2019 at 05:32:43PM +0800, kaixuxia wrote:
> The xfs_bumplink() call has set the inode log fieldmask XFS_ILOG_CORE,
> so the next xfs_trans_log_inode() call is not necessary.
> 
> Signed-off-by: kaixuxia <kaixuxia@tencent.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/xfs/xfs_inode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index 18f4b26..b0c81f1d 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -3327,7 +3327,6 @@ struct xfs_iunlink {
>  			goto out_trans_cancel;
>  
>  		xfs_bumplink(tp, wip);
> -		xfs_trans_log_inode(tp, wip, XFS_ILOG_CORE);
>  		VFS_I(wip)->i_state &= ~I_LINKABLE;
>  	}
>  
> -- 
> 1.8.3.1
> 
> -- 
> kaixuxia

Patch
diff mbox series

diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 18f4b26..b0c81f1d 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -3327,7 +3327,6 @@  struct xfs_iunlink {
 			goto out_trans_cancel;
 
 		xfs_bumplink(tp, wip);
-		xfs_trans_log_inode(tp, wip, XFS_ILOG_CORE);
 		VFS_I(wip)->i_state &= ~I_LINKABLE;
 	}