From patchwork Mon Oct 21 09:37:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qu Wenruo X-Patchwork-Id: 11201691 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0AA8813BD for ; Mon, 21 Oct 2019 09:38:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E470F20B7C for ; Mon, 21 Oct 2019 09:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727526AbfJUJiF (ORCPT ); Mon, 21 Oct 2019 05:38:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:37920 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726977AbfJUJiE (ORCPT ); Mon, 21 Oct 2019 05:38:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 008A9B777 for ; Mon, 21 Oct 2019 09:38:02 +0000 (UTC) From: Qu Wenruo To: linux-btrfs@vger.kernel.org Subject: [PATCH 1/3] btrfs-progs: utils-lib: Use error() to replace fprintf(stderr, "ERROR: ") Date: Mon, 21 Oct 2019 17:37:53 +0800 Message-Id: <20191021093755.56835-2-wqu@suse.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191021093755.56835-1-wqu@suse.com> References: <20191021093755.56835-1-wqu@suse.com> MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org This saves several lines of code. Signed-off-by: Qu Wenruo Reviewed-by: Johannes Thumshirn --- utils-lib.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/utils-lib.c b/utils-lib.c index c2b6097f5df9..0202dd7677f0 100644 --- a/utils-lib.c +++ b/utils-lib.c @@ -23,8 +23,7 @@ u64 arg_strtou64(const char *str) value = strtoull(str, &ptr_parse_end, 0); if (ptr_parse_end && *ptr_parse_end != '\0') { - fprintf(stderr, "ERROR: %s is not a valid numeric value.\n", - str); + error("%s is not a valid numeric value.", str); exit(1); } @@ -33,12 +32,11 @@ u64 arg_strtou64(const char *str) * unexpected number to us, so let's do the check ourselves. */ if (str[0] == '-') { - fprintf(stderr, "ERROR: %s: negative value is invalid.\n", - str); + error("%s: negative value is invalid.", str); exit(1); } if (value == ULLONG_MAX) { - fprintf(stderr, "ERROR: %s is too large.\n", str); + error("%s is too large.", str); exit(1); } return value;