[V2,1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
diff mbox series

Message ID 1571652977-4754-1-git-send-email-peng.fan@nxp.com
State New
Headers show
Series
  • [V2,1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
Related show

Commit Message

Peng Fan Oct. 21, 2019, 10:19 a.m. UTC
From: Peng Fan <peng.fan@nxp.com>

We should not rely on bootloader to configure the phy reset.
So introduce phy-reset-gpios property to let Linux handle phy reset
itself.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
---

V2:
 U-Boot->bootloader
 Add R-b tag

 arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Shawn Guo Oct. 28, 2019, 6:04 a.m. UTC | #1
On Mon, Oct 21, 2019 at 10:19:17AM +0000, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> We should not rely on bootloader to configure the phy reset.
> So introduce phy-reset-gpios property to let Linux handle phy reset
> itself.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

Applied both, thanks.
Leonard Crestez Oct. 31, 2019, 6:59 p.m. UTC | #2
On 21.10.2019 13:19, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> We should not rely on bootloader to configure the phy reset.
> So introduce phy-reset-gpios property to let Linux handle phy reset
> itself.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

This broke NFS boot for me in next-20191031: board now hangs on DHCP.

It can be fixed by reverting this DT patch or by setting 
CONFIG_AT803X_PHY to y instead of m.

Needing a phy module is not a bug but everybody will need to either 
adjust .config or build modules into an initramfs somehow.

> ---
> 
> V2:
>   U-Boot->bootloader
>   Add R-b tag
> 
>   arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index faefb7182af1..e4d66f7db09d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -80,6 +80,7 @@
>   	pinctrl-0 = <&pinctrl_fec1>;
>   	phy-mode = "rgmii-id";
>   	phy-handle = <&ethphy0>;
> +	phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
>   	fsl,magic-packet;
>   	status = "okay";
Peng Fan Nov. 1, 2019, 1:20 a.m. UTC | #3
> Subject: Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
> fec1
> 
> On 21.10.2019 13:19, Peng Fan wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > We should not rely on bootloader to configure the phy reset.
> > So introduce phy-reset-gpios property to let Linux handle phy reset
> > itself.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> 
> This broke NFS boot for me in next-20191031: board now hangs on DHCP.
> 

Sorry for this. I not use sdcard when I did the test.

> It can be fixed by reverting this DT patch or by setting CONFIG_AT803X_PHY
> to y instead of m.

I prefer setting CONFIG_AT803X_PHY.

Thanks,
Peng.

> 
> Needing a phy module is not a bug but everybody will need to either
> adjust .config or build modules into an initramfs somehow.
> 
> > ---
> >
> > V2:
> >   U-Boot->bootloader
> >   Add R-b tag
> >
> >   arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > index faefb7182af1..e4d66f7db09d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > @@ -80,6 +80,7 @@
> >   	pinctrl-0 = <&pinctrl_fec1>;
> >   	phy-mode = "rgmii-id";
> >   	phy-handle = <&ethphy0>;
> > +	phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
> >   	fsl,magic-packet;
> >   	status = "okay";
Shawn Guo Nov. 4, 2019, 12:51 a.m. UTC | #4
On Thu, Oct 31, 2019 at 06:59:51PM +0000, Leonard Crestez wrote:
> On 21.10.2019 13:19, Peng Fan wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> > 
> > We should not rely on bootloader to configure the phy reset.
> > So introduce phy-reset-gpios property to let Linux handle phy reset
> > itself.
> > 
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> 
> This broke NFS boot for me in next-20191031: board now hangs on DHCP.

I dropped both patches for now.

Shawn

> 
> It can be fixed by reverting this DT patch or by setting 
> CONFIG_AT803X_PHY to y instead of m.
> 
> Needing a phy module is not a bug but everybody will need to either 
> adjust .config or build modules into an initramfs somehow.

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
index faefb7182af1..e4d66f7db09d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
@@ -80,6 +80,7 @@ 
 	pinctrl-0 = <&pinctrl_fec1>;
 	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy0>;
+	phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
 	fsl,magic-packet;
 	status = "okay";