diff mbox series

usb: dwc3: select CONFIG_REGMAP_MMIO

Message ID 20191021141847.2214613-1-arnd@arndb.de (mailing list archive)
State Mainlined
Commit a51bab592fbbef10f0e42a8aed86adfbf6a68fa7
Headers show
Series usb: dwc3: select CONFIG_REGMAP_MMIO | expand

Commit Message

Arnd Bergmann Oct. 21, 2019, 2:18 p.m. UTC 
After many randconfig builds, one configuration caused a link
error with dwc3-meson-g12a lacking the regmap-mmio code:

drivers/usb/dwc3/dwc3-meson-g12a.o: In function `dwc3_meson_g12a_probe':
dwc3-meson-g12a.c:(.text+0x9f): undefined reference to `__devm_regmap_init_mmio_clk'

Add the select statement that we have for all other users
of that dependency.

Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/usb/dwc3/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Neil Armstrong Oct. 21, 2019, 2:19 p.m. UTC | #1 
On 21/10/2019 16:18, Arnd Bergmann wrote:
> After many randconfig builds, one configuration caused a link
> error with dwc3-meson-g12a lacking the regmap-mmio code:
> 
> drivers/usb/dwc3/dwc3-meson-g12a.o: In function `dwc3_meson_g12a_probe':
> dwc3-meson-g12a.c:(.text+0x9f): undefined reference to `__devm_regmap_init_mmio_clk'
> 
> Add the select statement that we have for all other users
> of that dependency.
> 
> Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/usb/dwc3/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 89abc6078703..556a876c7896 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -102,6 +102,7 @@ config USB_DWC3_MESON_G12A
>         depends on ARCH_MESON || COMPILE_TEST
>         default USB_DWC3
>         select USB_ROLE_SWITCH
> +	select REGMAP_MMIO
>         help
>           Support USB2/3 functionality in Amlogic G12A platforms.
>  	 Say 'Y' or 'M' if you have one such device.
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>
diff mbox series

Patch

diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index 89abc6078703..556a876c7896 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -102,6 +102,7 @@  config USB_DWC3_MESON_G12A
        depends on ARCH_MESON || COMPILE_TEST
        default USB_DWC3
        select USB_ROLE_SWITCH
+	select REGMAP_MMIO
        help
          Support USB2/3 functionality in Amlogic G12A platforms.
 	 Say 'Y' or 'M' if you have one such device.