python/semanage: Document DCCP and SCTP support
diff mbox series

Message ID 20191021143736.13456-1-vmojzis@redhat.com
State Accepted
Headers show
Series
  • python/semanage: Document DCCP and SCTP support
Related show

Commit Message

Vit Mojzis Oct. 21, 2019, 2:37 p.m. UTC
Add DCCP and SCTP protocols in semanage port man page and --help
message.

Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
---
 python/semanage/semanage        | 5 +----
 python/semanage/semanage-port.8 | 2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

Comments

Stephen Smalley Oct. 23, 2019, 2:27 p.m. UTC | #1
On 10/21/19 10:37 AM, Vit Mojzis wrote:
> Add DCCP and SCTP protocols in semanage port man page and --help
> message.
> 
> Signed-off-by: Vit Mojzis <vmojzis@redhat.com>

Thanks, applied but see note below for future reference.

> ---
>   python/semanage/semanage        | 5 +----
>   python/semanage/semanage-port.8 | 2 +-
>   2 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/python/semanage/semanage b/python/semanage/semanage
> index 864f9212..b2fabea6 100644
> --- a/python/semanage/semanage
> +++ b/python/semanage/semanage
> @@ -73,9 +73,6 @@ usage_interface_dict = {' --add': ('-t TYPE', '-r RANGE', 'interface'), ' --modi
>   usage_boolean = "semanage boolean [-h] [-n] [-N] [-S STORE] ["
>   usage_boolean_dict = {' --modify': ('(', '--on', '|', '--off', ')', 'boolean'), ' --list': ('-C',), '  --extract': ('',), ' --deleteall': ('',)}
>   
> -
> -
> -

Generally you should avoid unrelated whitespace fixes in a patch and put 
those in a separate patch.

>   class CheckRole(argparse.Action):
>   
>       def __call__(self, parser, namespace, value, option_string=None):
> @@ -248,7 +245,7 @@ SELinux Range for SELinux user defaults to s0.
>   
>   def parser_add_proto(parser, name):
>       parser.add_argument('-p', '--proto', help=_('''
> -    Protocol  for  the specified port (tcp|udp) or internet protocol
> +    Protocol  for  the specified port (tcp|udp|dccp|sctp) or internet protocol
>       version for the specified node (ipv4|ipv6).
>   '''))
>   
> diff --git a/python/semanage/semanage-port.8 b/python/semanage/semanage-port.8
> index a21287c0..12ec14c2 100644
> --- a/python/semanage/semanage-port.8
> +++ b/python/semanage/semanage-port.8
> @@ -49,7 +49,7 @@ SELinux type for the object
>   MLS/MCS Security Range (MLS/MCS Systems only) SELinux Range for SELinux login mapping defaults to the SELinux user record range. SELinux Range for SELinux user defaults to s0.
>   .TP
>   .I   \-p PROTO, \-\-proto PROTO
> -Protocol for the specified port (tcp|udp) or internet protocol version for the specified node (ipv4|ipv6).
> +Protocol for the specified port (tcp|udp|dccp|sctp) or internet protocol version for the specified node (ipv4|ipv6).
>   
>   .SH EXAMPLE
>   .nf
>

Patch
diff mbox series

diff --git a/python/semanage/semanage b/python/semanage/semanage
index 864f9212..b2fabea6 100644
--- a/python/semanage/semanage
+++ b/python/semanage/semanage
@@ -73,9 +73,6 @@  usage_interface_dict = {' --add': ('-t TYPE', '-r RANGE', 'interface'), ' --modi
 usage_boolean = "semanage boolean [-h] [-n] [-N] [-S STORE] ["
 usage_boolean_dict = {' --modify': ('(', '--on', '|', '--off', ')', 'boolean'), ' --list': ('-C',), '  --extract': ('',), ' --deleteall': ('',)}
 
-
-
-
 class CheckRole(argparse.Action):
 
     def __call__(self, parser, namespace, value, option_string=None):
@@ -248,7 +245,7 @@  SELinux Range for SELinux user defaults to s0.
 
 def parser_add_proto(parser, name):
     parser.add_argument('-p', '--proto', help=_('''
-    Protocol  for  the specified port (tcp|udp) or internet protocol
+    Protocol  for  the specified port (tcp|udp|dccp|sctp) or internet protocol
     version for the specified node (ipv4|ipv6).
 '''))
 
diff --git a/python/semanage/semanage-port.8 b/python/semanage/semanage-port.8
index a21287c0..12ec14c2 100644
--- a/python/semanage/semanage-port.8
+++ b/python/semanage/semanage-port.8
@@ -49,7 +49,7 @@  SELinux type for the object
 MLS/MCS Security Range (MLS/MCS Systems only) SELinux Range for SELinux login mapping defaults to the SELinux user record range. SELinux Range for SELinux user defaults to s0.
 .TP
 .I   \-p PROTO, \-\-proto PROTO
-Protocol for the specified port (tcp|udp) or internet protocol version for the specified node (ipv4|ipv6).
+Protocol for the specified port (tcp|udp|dccp|sctp) or internet protocol version for the specified node (ipv4|ipv6).
 
 .SH EXAMPLE
 .nf