power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static
diff mbox series

Message ID 1571672407-58950-1-git-send-email-zhongjiang@huawei.com
State Not Applicable, archived
Headers show
Series
  • power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static
Related show

Commit Message

zhong jiang Oct. 21, 2019, 3:40 p.m. UTC
The GCC complains the following case when compiling kernel.

drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 drivers/power/supply/cpcap-charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sebastian Reichel Oct. 21, 2019, 5:04 p.m. UTC | #1
Hi,

On Mon, Oct 21, 2019 at 11:40:07PM +0800, zhong jiang wrote:
> The GCC complains the following case when compiling kernel.
> 
> drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---

Thanks, but Intel's kbuild test robot was faster than you:

https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/commit/?h=for-next

-- Sebastian
zhong jiang Oct. 28, 2019, 4:16 p.m. UTC | #2
ping.

On 2019/10/21 23:40, zhong jiang wrote:
> The GCC complains the following case when compiling kernel.
>
> drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  drivers/power/supply/cpcap-charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
> index 40d96b8..c0d452e 100644
> --- a/drivers/power/supply/cpcap-charger.c
> +++ b/drivers/power/supply/cpcap-charger.c
> @@ -560,7 +560,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
>  	dev_dbg(ddata->dev, "state: %s\n", status);
>  }
>  
> -int cpcap_charger_voltage_to_regval(int voltage)
> +static int cpcap_charger_voltage_to_regval(int voltage)
>  {
>  	int offset;
>
Sebastian Reichel Oct. 28, 2019, 9:56 p.m. UTC | #3
Hi,

https://lkml.org/lkml/2019/10/21/1018

That's e3da2ce04e12 to be specific.

-- Sebastian

On Tue, Oct 29, 2019 at 12:16:37AM +0800, zhong jiang wrote:
> ping.
> 
> On 2019/10/21 23:40, zhong jiang wrote:
> > The GCC complains the following case when compiling kernel.
> >
> > drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
> >
> > Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> > ---
> >  drivers/power/supply/cpcap-charger.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
> > index 40d96b8..c0d452e 100644
> > --- a/drivers/power/supply/cpcap-charger.c
> > +++ b/drivers/power/supply/cpcap-charger.c
> > @@ -560,7 +560,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
> >  	dev_dbg(ddata->dev, "state: %s\n", status);
> >  }
> >  
> > -int cpcap_charger_voltage_to_regval(int voltage)
> > +static int cpcap_charger_voltage_to_regval(int voltage)
> >  {
> >  	int offset;
> >  
> 
>
zhong jiang Oct. 29, 2019, 3:09 a.m. UTC | #4
Sorry,  I forget that.

Thanks,
zhogn jiang
On 2019/10/29 5:56, Sebastian Reichel wrote:
> Hi,
>
> https://lkml.org/lkml/2019/10/21/1018
>
> That's e3da2ce04e12 to be specific.
>
> -- Sebastian
>
> On Tue, Oct 29, 2019 at 12:16:37AM +0800, zhong jiang wrote:
>> ping.
>>
>> On 2019/10/21 23:40, zhong jiang wrote:
>>> The GCC complains the following case when compiling kernel.
>>>
>>> drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
>>>
>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>>> ---
>>>  drivers/power/supply/cpcap-charger.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
>>> index 40d96b8..c0d452e 100644
>>> --- a/drivers/power/supply/cpcap-charger.c
>>> +++ b/drivers/power/supply/cpcap-charger.c
>>> @@ -560,7 +560,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
>>>  	dev_dbg(ddata->dev, "state: %s\n", status);
>>>  }
>>>  
>>> -int cpcap_charger_voltage_to_regval(int voltage)
>>> +static int cpcap_charger_voltage_to_regval(int voltage)
>>>  {
>>>  	int offset;
>>>  
>>

Patch
diff mbox series

diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
index 40d96b8..c0d452e 100644
--- a/drivers/power/supply/cpcap-charger.c
+++ b/drivers/power/supply/cpcap-charger.c
@@ -560,7 +560,7 @@  static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
 	dev_dbg(ddata->dev, "state: %s\n", status);
 }
 
-int cpcap_charger_voltage_to_regval(int voltage)
+static int cpcap_charger_voltage_to_regval(int voltage)
 {
 	int offset;