drm/i915/selftests: Use all physical engines for i915_active
diff mbox series

Message ID 20191021162146.1686-1-chris@chris-wilson.co.uk
State New
Headers show
Series
  • drm/i915/selftests: Use all physical engines for i915_active
Related show

Commit Message

Chris Wilson Oct. 21, 2019, 4:21 p.m. UTC
i915_active must track over any engine, so expand the selftest to
iterate over all uabi engines.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/selftests/i915_active.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Tvrtko Ursulin Oct. 21, 2019, 5:06 p.m. UTC | #1
On 21/10/2019 17:21, Chris Wilson wrote:
> i915_active must track over any engine, so expand the selftest to
> iterate over all uabi engines.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/selftests/i915_active.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/selftests/i915_active.c b/drivers/gpu/drm/i915/selftests/i915_active.c
> index 268192b5613b..96513a7d4739 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_active.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_active.c
> @@ -79,7 +79,6 @@ __live_active_setup(struct drm_i915_private *i915)
>   	struct intel_engine_cs *engine;
>   	struct i915_sw_fence *submit;
>   	struct live_active *active;
> -	enum intel_engine_id id;
>   	unsigned int count = 0;
>   	int err = 0;
>   
> @@ -97,7 +96,7 @@ __live_active_setup(struct drm_i915_private *i915)
>   	if (err)
>   		goto out;
>   
> -	for_each_engine(engine, i915, id) {
> +	for_each_uabi_engine(engine, i915) {
>   		struct i915_request *rq;
>   
>   		rq = i915_request_create(engine->kernel_context);
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/selftests/i915_active.c b/drivers/gpu/drm/i915/selftests/i915_active.c
index 268192b5613b..96513a7d4739 100644
--- a/drivers/gpu/drm/i915/selftests/i915_active.c
+++ b/drivers/gpu/drm/i915/selftests/i915_active.c
@@ -79,7 +79,6 @@  __live_active_setup(struct drm_i915_private *i915)
 	struct intel_engine_cs *engine;
 	struct i915_sw_fence *submit;
 	struct live_active *active;
-	enum intel_engine_id id;
 	unsigned int count = 0;
 	int err = 0;
 
@@ -97,7 +96,7 @@  __live_active_setup(struct drm_i915_private *i915)
 	if (err)
 		goto out;
 
-	for_each_engine(engine, i915, id) {
+	for_each_uabi_engine(engine, i915) {
 		struct i915_request *rq;
 
 		rq = i915_request_create(engine->kernel_context);