| Message ID | 0812dca3-8447-be46-b84c-e89f25176cbf@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt() | expand |
On Tue, 22 Oct 2019 at 09:28, Yunfeng Ye <yeyunfeng@huawei.com> wrote: > > A warning is found by the static code analysis tool: > "Identical condition 'err', second condition is always false" > > Fix this by adding return value of skcipher_walk_done(). > > Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS") > Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > v1 -> v2: > - update the subject and comment > - add return value of skcipher_walk_done() > > arch/arm64/crypto/aes-neonbs-glue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c > index ea873b8904c4..e3e27349a9fe 100644 > --- a/arch/arm64/crypto/aes-neonbs-glue.c > +++ b/arch/arm64/crypto/aes-neonbs-glue.c > @@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt, > goto xts_tail; > > kernel_neon_end(); > - skcipher_walk_done(&walk, nbytes); > + err = skcipher_walk_done(&walk, nbytes); > } > > if (err || likely(!tail)) > -- > 2.7.4.3 >
diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c index ea873b8904c4..e3e27349a9fe 100644 --- a/arch/arm64/crypto/aes-neonbs-glue.c +++ b/arch/arm64/crypto/aes-neonbs-glue.c @@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt, goto xts_tail; kernel_neon_end(); - skcipher_walk_done(&walk, nbytes); + err = skcipher_walk_done(&walk, nbytes); } if (err || likely(!tail))
A warning is found by the static code analysis tool: "Identical condition 'err', second condition is always false" Fix this by adding return value of skcipher_walk_done(). Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS") Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com> --- v1 -> v2: - update the subject and comment - add return value of skcipher_walk_done() arch/arm64/crypto/aes-neonbs-glue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)