| Message ID | 20191023114824.30509-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | crypto: mediatek: remove redundant bitwise-or | expand |
On Wed, Oct 23, 2019 at 12:48:24PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Bitwise-or'ing 0xffffffff with the u32 variable ctr is the same result > as assigning the value to ctr. Remove the redundant bitwise-or and > just use an assignment. > > Addresses-Coverity: ("Suspicious &= or |= constant expression") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/crypto/mediatek/mtk-aes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/mediatek/mtk-aes.c b/drivers/crypto/mediatek/mtk-aes.c index 90c9644fb8a8..d43410259113 100644 --- a/drivers/crypto/mediatek/mtk-aes.c +++ b/drivers/crypto/mediatek/mtk-aes.c @@ -591,7 +591,7 @@ static int mtk_aes_ctr_transfer(struct mtk_cryp *cryp, struct mtk_aes_rec *aes) start = ctr; end = start + blocks - 1; if (end < start) { - ctr |= 0xffffffff; + ctr = 0xffffffff; datalen = AES_BLOCK_SIZE * -start; fragmented = true; }