[v4,2/7] Makefile: rockchip: Suffix platform type with tpl name
diff mbox series

Message ID 20191023195652.7158-3-jagan@amarulasolutions.com
State New
Headers show
Series
  • rockchip: Add Binman support
Related show

Commit Message

Jagan Teki Oct. 23, 2019, 7:56 p.m. UTC
Most of the platforms uses the platform type on their boot
stage image naming conventions in makefile like,

u-boot-x86-start16-tpl.bin - x86 start16 TPL bin
u-boot-spl-mtk.bin - Mediatek SPL bin

This would help to understand the users to what that
particular image belongs to? and less confused.

On that note, suffix platform type rockchip for existing
u-boot-tpl.img so now it become u-boot-tpl-rockchip.bin

Also, bin is more conventional way to include it on tools
like binman, pad_cat etc in future patches.

Note: usage of platform type doesn't follow consistent order
as of now.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Kever Yang Nov. 10, 2019, 2:18 p.m. UTC | #1
On 2019/10/24 上午3:56, Jagan Teki wrote:
> Most of the platforms uses the platform type on their boot
> stage image naming conventions in makefile like,
>
> u-boot-x86-start16-tpl.bin - x86 start16 TPL bin
> u-boot-spl-mtk.bin - Mediatek SPL bin
>
> This would help to understand the users to what that
> particular image belongs to? and less confused.
>
> On that note, suffix platform type rockchip for existing
> u-boot-tpl.img so now it become u-boot-tpl-rockchip.bin
>
> Also, bin is more conventional way to include it on tools
> like binman, pad_cat etc in future patches.
>
> Note: usage of platform type doesn't follow consistent order
> as of now.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   Makefile | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 3e05d3fcfe..40cbf68fef 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1342,10 +1342,10 @@ else
>   ROCKCHIP_IMG_TYPE := rksd
>   endif
>   
> -MKIMAGEFLAGS_u-boot-tpl.img = -n $(CONFIG_SYS_SOC) -T $(ROCKCHIP_IMG_TYPE)
> -tpl/u-boot-tpl.img: tpl/u-boot-tpl.bin FORCE
> +MKIMAGEFLAGS_u-boot-tpl-rockchip.bin = -n $(CONFIG_SYS_SOC) -T $(ROCKCHIP_IMG_TYPE)
> +tpl/u-boot-tpl-rockchip.bin: tpl/u-boot-tpl.bin FORCE
>   	$(call if_changed,mkimage)
> -idbloader.img: tpl/u-boot-tpl.img spl/u-boot-spl.bin FORCE
> +idbloader.img: tpl/u-boot-tpl-rockchip.bin spl/u-boot-spl.bin FORCE
>   	$(call if_changed,cat)
>   endif
>

Patch
diff mbox series

diff --git a/Makefile b/Makefile
index 3e05d3fcfe..40cbf68fef 100644
--- a/Makefile
+++ b/Makefile
@@ -1342,10 +1342,10 @@  else
 ROCKCHIP_IMG_TYPE := rksd
 endif
 
-MKIMAGEFLAGS_u-boot-tpl.img = -n $(CONFIG_SYS_SOC) -T $(ROCKCHIP_IMG_TYPE)
-tpl/u-boot-tpl.img: tpl/u-boot-tpl.bin FORCE
+MKIMAGEFLAGS_u-boot-tpl-rockchip.bin = -n $(CONFIG_SYS_SOC) -T $(ROCKCHIP_IMG_TYPE)
+tpl/u-boot-tpl-rockchip.bin: tpl/u-boot-tpl.bin FORCE
 	$(call if_changed,mkimage)
-idbloader.img: tpl/u-boot-tpl.img spl/u-boot-spl.bin FORCE
+idbloader.img: tpl/u-boot-tpl-rockchip.bin spl/u-boot-spl.bin FORCE
 	$(call if_changed,cat)
 endif