| Message ID | 20191024110618.6436-1-wl@xen.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [for-4.13] CONTRIBUTING: drop reference to blktap2 | expand |
On 24.10.19 13:06, Wei Liu wrote: > Blktap2 is gone. > > Signed-off-by: Wei Liu <wl@xen.org> > --- > CONTRIBUTING | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/CONTRIBUTING b/CONTRIBUTING > index 47f53e9a49..4fff4fd9f6 100644 > --- a/CONTRIBUTING > +++ b/CONTRIBUTING > @@ -13,7 +13,6 @@ Most of the Xen Project code is licensed under GPLv2, but a number of > directories are primarily licensed under different licenses. > > Most notably: > - - tools/blktap2 : BSD-Modified > - tools/libxc : LGPL v2.1 > - tools/libxl : LGPL v2.1 > - tools/xl : LGPL v2.1 > Mind adding tools/libs instead? With that: Reviewed-by: Juergen Gross <jgross@suse.com> Release-acked-by: Juergen Gross <jgross@suse.com> Juergen
On Thu, Oct 24, 2019 at 01:13:13PM +0200, Jürgen Groß wrote: > On 24.10.19 13:06, Wei Liu wrote: > > Blktap2 is gone. > > > > Signed-off-by: Wei Liu <wl@xen.org> > > --- > > CONTRIBUTING | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/CONTRIBUTING b/CONTRIBUTING > > index 47f53e9a49..4fff4fd9f6 100644 > > --- a/CONTRIBUTING > > +++ b/CONTRIBUTING > > @@ -13,7 +13,6 @@ Most of the Xen Project code is licensed under GPLv2, but a number of > > directories are primarily licensed under different licenses. > > Most notably: > > - - tools/blktap2 : BSD-Modified > > - tools/libxc : LGPL v2.1 > > - tools/libxl : LGPL v2.1 > > - tools/xl : LGPL v2.1 > > > > Mind adding tools/libs instead? Sure. That can be done. Because tools/libs' code is mostly split from libxc and friends, I assume it is going to be LGPL v2.1 as well. Lars and Ian, your opinion? Wei. > > With that: > > Reviewed-by: Juergen Gross <jgross@suse.com> > Release-acked-by: Juergen Gross <jgross@suse.com> > > > Juergen > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/xen-devel
On 24/10/2019, 12:22, "Wei Liu" <wl@xen.org> wrote:
On Thu, Oct 24, 2019 at 01:13:13PM +0200, Jürgen Groß wrote:
> On 24.10.19 13:06, Wei Liu wrote:
> > Blktap2 is gone.
> >
> > Signed-off-by: Wei Liu <wl@xen.org>
> > ---
> > CONTRIBUTING | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/CONTRIBUTING b/CONTRIBUTING
> > index 47f53e9a49..4fff4fd9f6 100644
> > --- a/CONTRIBUTING
> > +++ b/CONTRIBUTING
> > @@ -13,7 +13,6 @@ Most of the Xen Project code is licensed under GPLv2, but a number of
> > directories are primarily licensed under different licenses.
> > Most notably:
> > - - tools/blktap2 : BSD-Modified
> > - tools/libxc : LGPL v2.1
> > - tools/libxl : LGPL v2.1
> > - tools/xl : LGPL v2.1
> >
>
> Mind adding tools/libs instead?
Sure. That can be done.
Because tools/libs' code is mostly split from libxc and friends, I
assume it is going to be LGPL v2.1 as well.
Lars and Ian, your opinion?
Tools/libs does not have a COPYING file, so it is GPL by default. However, all the files I checked appear to have LGPL v2.1
So, the directory should probably have an appropriate COPYING file, but we do need to check all files in it
Regards
Lars
Wei Liu writes ("Re: [Xen-devel] [PATCH for-4.13] CONTRIBUTING: drop reference to blktap2"):
> On Thu, Oct 24, 2019 at 01:13:13PM +0200, Jürgen Groß wrote:
> > Mind adding tools/libs instead?
>
> Sure. That can be done.
>
> Because tools/libs' code is mostly split from libxc and friends, I
> assume it is going to be LGPL v2.1 as well.
>
> Lars and Ian, your opinion?
Err, this is surely a mechanical question ? Ie, what licence are
these files in already.
I did
git-grep -i -l copyright | xargs git-grep -L 'GNU Lesser General'
in tools/libs and there were no hits.
So I think the answer is indeed LGPL.
Ian.
On 24.10.19 14:14, Lars Kurth wrote: > > > On 24/10/2019, 12:22, "Wei Liu" <wl@xen.org> wrote: > > On Thu, Oct 24, 2019 at 01:13:13PM +0200, Jürgen Groß wrote: > > On 24.10.19 13:06, Wei Liu wrote: > > > Blktap2 is gone. > > > > > > Signed-off-by: Wei Liu <wl@xen.org> > > > --- > > > CONTRIBUTING | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/CONTRIBUTING b/CONTRIBUTING > > > index 47f53e9a49..4fff4fd9f6 100644 > > > --- a/CONTRIBUTING > > > +++ b/CONTRIBUTING > > > @@ -13,7 +13,6 @@ Most of the Xen Project code is licensed under GPLv2, but a number of > > > directories are primarily licensed under different licenses. > > > Most notably: > > > - - tools/blktap2 : BSD-Modified > > > - tools/libxc : LGPL v2.1 > > > - tools/libxl : LGPL v2.1 > > > - tools/xl : LGPL v2.1 > > > > > > > Mind adding tools/libs instead? > > Sure. That can be done. > > Because tools/libs' code is mostly split from libxc and friends, I > assume it is going to be LGPL v2.1 as well. > > Lars and Ian, your opinion? > > Tools/libs does not have a COPYING file, so it is GPL by default. However, all the files I checked appear to have LGPL v2.1 > So, the directory should probably have an appropriate COPYING file, but we do need to check all files in it tools/libs/*/private.h have no license remark, all other *.c and *.h are LGPL 2.1. Juergen
diff --git a/CONTRIBUTING b/CONTRIBUTING index 47f53e9a49..4fff4fd9f6 100644 --- a/CONTRIBUTING +++ b/CONTRIBUTING @@ -13,7 +13,6 @@ Most of the Xen Project code is licensed under GPLv2, but a number of directories are primarily licensed under different licenses. Most notably: - - tools/blktap2 : BSD-Modified - tools/libxc : LGPL v2.1 - tools/libxl : LGPL v2.1 - tools/xl : LGPL v2.1
Blktap2 is gone. Signed-off-by: Wei Liu <wl@xen.org> --- CONTRIBUTING | 1 - 1 file changed, 1 deletion(-)