[v2] Fix segmentation fault in trace-cmd record on invalid event hooks
diff mbox series

Message ID 20191024124517.19320-1-kaslevs@vmware.com
State Accepted
Headers show
Series
  • [v2] Fix segmentation fault in trace-cmd record on invalid event hooks
Related show

Commit Message

Slavomir Kaslev Oct. 24, 2019, 12:45 p.m. UTC
Currently passing an invalid event hook to trace-cmd record causes a
segmentation fault, e.g.

$ sudo trace-cmd record -e irq -H foobar
  Invalid hook format 'foobar'
  Segmentation fault

Fix this by checking the return value of tracecmd_create_event_hook().

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
---
Changes in v2:
 - fixed commit message

 tracecmd/trace-record.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.20.1

Patch
diff mbox series

diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index c65731f..0596b63 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -4632,6 +4632,8 @@  static void add_hook(struct buffer_instance *instance, const char *arg)
 	struct hook_list *hook;

 	hook = tracecmd_create_event_hook(arg);
+	if (!hook)
+		die("Failed to create event hook %s", arg);

 	hook->instance = instance;
 	hook->next = hooks;