[1/3] dt-bindings: arm: Add devicetree binding for Thor96 Board
diff mbox series

Message ID 20191024144235.3182-2-manivannan.sadhasivam@linaro.org
State New
Headers show
Series
  • Add support for Thor96 board
Related show

Commit Message

Manivannan Sadhasivam Oct. 24, 2019, 2:42 p.m. UTC
Add devicetree binding for Thor96 Board from Einfochips. This board is
one of the 96Boards Consumer Edition platform powered by NXP i.MX8MQ SoC.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Marco Felsch Oct. 25, 2019, 6:26 a.m. UTC | #1
Hi Manivannan,

On 19-10-24 20:12, Manivannan Sadhasivam wrote:
> Add devicetree binding for Thor96 Board from Einfochips. This board is
> one of the 96Boards Consumer Edition platform powered by NXP i.MX8MQ SoC.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 1b4b4e6573b5..8016174d5e49 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -239,6 +239,7 @@ properties:
>          items:
>            - enum:
>                - boundary,imx8mq-nitrogen8m # i.MX8MQ NITROGEN Board
> +              - einfochips,imx8mq-thor96  # i.MX8MQ Thor96 Board

Do we need to add a vendor patch too?

Regards,
  Marco

>                - fsl,imx8mq-evk            # i.MX8MQ EVK Board
>                - purism,librem5-devkit     # Purism Librem5 devkit
>                - solidrun,hummingboard-pulse # SolidRun Hummingboard Pulse
> -- 
> 2.17.1
> 
> 
>
Manivannan Sadhasivam Oct. 25, 2019, 7:19 a.m. UTC | #2
Hi Marco,

On Fri, Oct 25, 2019 at 08:26:59AM +0200, Marco Felsch wrote:
> Hi Manivannan,
> 
> On 19-10-24 20:12, Manivannan Sadhasivam wrote:
> > Add devicetree binding for Thor96 Board from Einfochips. This board is
> > one of the 96Boards Consumer Edition platform powered by NXP i.MX8MQ SoC.
> > 
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 1b4b4e6573b5..8016174d5e49 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -239,6 +239,7 @@ properties:
> >          items:
> >            - enum:
> >                - boundary,imx8mq-nitrogen8m # i.MX8MQ NITROGEN Board
> > +              - einfochips,imx8mq-thor96  # i.MX8MQ Thor96 Board
> 
> Do we need to add a vendor patch too?
> 

Do you mean a patch for adding vendor prefix? If yes, then I have added it
already for AI_ML board and it is in mainline now!

https://elixir.bootlin.com/linux/v5.4-rc2/source/Documentation/devicetree/bindings/vendor-prefixes.yaml#L276

Thanks,
Mani

> Regards,
>   Marco
> 
> >                - fsl,imx8mq-evk            # i.MX8MQ EVK Board
> >                - purism,librem5-devkit     # Purism Librem5 devkit
> >                - solidrun,hummingboard-pulse # SolidRun Hummingboard Pulse
> > -- 
> > 2.17.1
> > 
> > 
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Marco Felsch Oct. 25, 2019, 12:15 p.m. UTC | #3
Hi Manivannan,

On 19-10-25 12:49, Manivannan Sadhasivam wrote:
> 
> Hi Marco,
> 
> On Fri, Oct 25, 2019 at 08:26:59AM +0200, Marco Felsch wrote:
> > Hi Manivannan,
> > 
> > On 19-10-24 20:12, Manivannan Sadhasivam wrote:
> > > Add devicetree binding for Thor96 Board from Einfochips. This board is
> > > one of the 96Boards Consumer Edition platform powered by NXP i.MX8MQ SoC.
> > > 
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > >  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > index 1b4b4e6573b5..8016174d5e49 100644
> > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > @@ -239,6 +239,7 @@ properties:
> > >          items:
> > >            - enum:
> > >                - boundary,imx8mq-nitrogen8m # i.MX8MQ NITROGEN Board
> > > +              - einfochips,imx8mq-thor96  # i.MX8MQ Thor96 Board
> > 
> > Do we need to add a vendor patch too?
> > 
> 
> Do you mean a patch for adding vendor prefix? If yes, then I have added it
> already for AI_ML board and it is in mainline now!
> 
> https://elixir.bootlin.com/linux/v5.4-rc2/source/Documentation/devicetree/bindings/vendor-prefixes.yaml#L276

Ah, okay thanks for the hint. Feel free to add my:

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

Regards,
  Marco

> Thanks,
> Mani
> 
> > Regards,
> >   Marco
> > 
> > >                - fsl,imx8mq-evk            # i.MX8MQ EVK Board
> > >                - purism,librem5-devkit     # Purism Librem5 devkit
> > >                - solidrun,hummingboard-pulse # SolidRun Hummingboard Pulse
> > > -- 
> > > 2.17.1
> > > 
> > > 
> > > 
> > 
> > -- 
> > Pengutronix e.K.                           |                             |
> > Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>
Rob Herring Oct. 29, 2019, 7:37 p.m. UTC | #4
On Thu, 24 Oct 2019 20:12:33 +0530, Manivannan Sadhasivam wrote:
> Add devicetree binding for Thor96 Board from Einfochips. This board is
> one of the 96Boards Consumer Edition platform powered by NXP i.MX8MQ SoC.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 1b4b4e6573b5..8016174d5e49 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -239,6 +239,7 @@  properties:
         items:
           - enum:
               - boundary,imx8mq-nitrogen8m # i.MX8MQ NITROGEN Board
+              - einfochips,imx8mq-thor96  # i.MX8MQ Thor96 Board
               - fsl,imx8mq-evk            # i.MX8MQ EVK Board
               - purism,librem5-devkit     # Purism Librem5 devkit
               - solidrun,hummingboard-pulse # SolidRun Hummingboard Pulse