| Message ID | 20191024215723.145922-2-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | [v3,1/3] ACPI / LPSS: Add LNXVIDEO -> BYT I2C7 to lpss_device_links | expand |
On Thu, Oct 24, 2019 at 11:57:22PM +0200, Hans de Goede wrote: > Various Asus Bay Trail devices (T100TA, T100CHI, T200TA) have an embedded > controller connected to I2C1 and the iGPU (LNXVIDEO) _PS0/_PS3 methods > access it, so we need to add a consumer link from LNXVIDEO to I2C1 on > these devices to avoid suspend/resume ordering problems. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: stable@vger.kernel.org > Fixes: 2d71ee0ce72f ("ACPI / LPSS: Add a device link from the GPU to the BYT I2C5 controller") > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > Changes in v2: > -Add Fixes: tag > > Changes in v3: > -Point Fixes tag to a more apropriate commit > --- > drivers/acpi/acpi_lpss.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c > index e7a4504f0fbf..cd8cf3333f04 100644 > --- a/drivers/acpi/acpi_lpss.c > +++ b/drivers/acpi/acpi_lpss.c > @@ -477,6 +477,8 @@ static const struct lpss_device_links lpss_device_links[] = { > {"808622C1", "7", "80860F14", "3", DL_FLAG_PM_RUNTIME}, > /* CHT iGPU depends on PMIC I2C controller */ > {"808622C1", "7", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME}, > + /* BYT iGPU depends on the Embedded Controller I2C controller (UID 1) */ > + {"80860F41", "1", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME}, > /* BYT CR iGPU depends on PMIC I2C controller (UID 5 on CR) */ > {"80860F41", "5", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME}, > /* BYT iGPU depends on PMIC I2C controller (UID 7 on non CR) */ > -- > 2.23.0 >
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c index e7a4504f0fbf..cd8cf3333f04 100644 --- a/drivers/acpi/acpi_lpss.c +++ b/drivers/acpi/acpi_lpss.c @@ -477,6 +477,8 @@ static const struct lpss_device_links lpss_device_links[] = { {"808622C1", "7", "80860F14", "3", DL_FLAG_PM_RUNTIME}, /* CHT iGPU depends on PMIC I2C controller */ {"808622C1", "7", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME}, + /* BYT iGPU depends on the Embedded Controller I2C controller (UID 1) */ + {"80860F41", "1", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME}, /* BYT CR iGPU depends on PMIC I2C controller (UID 5 on CR) */ {"80860F41", "5", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME}, /* BYT iGPU depends on PMIC I2C controller (UID 7 on non CR) */
Various Asus Bay Trail devices (T100TA, T100CHI, T200TA) have an embedded controller connected to I2C1 and the iGPU (LNXVIDEO) _PS0/_PS3 methods access it, so we need to add a consumer link from LNXVIDEO to I2C1 on these devices to avoid suspend/resume ordering problems. Cc: stable@vger.kernel.org Fixes: 2d71ee0ce72f ("ACPI / LPSS: Add a device link from the GPU to the BYT I2C5 controller") Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- Changes in v2: -Add Fixes: tag Changes in v3: -Point Fixes tag to a more apropriate commit --- drivers/acpi/acpi_lpss.c | 2 ++ 1 file changed, 2 insertions(+)