| Message ID | 20191025124058.22580-21-linux@rasmusvillemoes.dk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | QUICC Engine support on ARM | expand |
> -----Original Message----- > From: Rasmus Villemoes <linux@rasmusvillemoes.dk> > Sent: Friday, October 25, 2019 7:41 AM > To: Qiang Zhao <qiang.zhao@nxp.com>; Leo Li <leoyang.li@nxp.com>; > Christophe Leroy <christophe.leroy@c-s.fr> > Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; Scott Wood <oss@buserror.net>; Valentin > Longchamp <valentin.longchamp@keymile.com>; Rasmus Villemoes > <linux@rasmusvillemoes.dk>; linux-serial@vger.kernel.org > Subject: [PATCH v2 20/23] serial: make SERIAL_QE depend on PPC32 > > Currently SERIAL_QE depends on QUICC_ENGINE, which in turn depends on > PPC32, so this doesn't add any extra dependency. However, the QUICC > Engine IP block also exists on some arm boards, so this serves as preparation > for removing the PPC32 dependency from QUICC_ENGINE and build the QE > support in drivers/soc/fsl/qe, while preventing allmodconfig/randconfig > failures due to SERIAL_QE not being supported yet. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> I think your purpose of this series is to make the QE UART not depending on PPC32. If it does accomplish that then we don't need this change. > --- > drivers/tty/serial/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index > 67a9eb3f94ce..78246f535809 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1056,6 +1056,7 @@ config SERIAL_LANTIQ config SERIAL_QE > tristate "Freescale QUICC Engine serial port support" > depends on QUICC_ENGINE > + depends on PPC32 > select SERIAL_CORE > select FW_LOADER > help > -- > 2.23.0
On 29/10/2019 23.44, Leo Li wrote: > > >> -----Original Message----- >> From: Rasmus Villemoes <linux@rasmusvillemoes.dk> >> Sent: Friday, October 25, 2019 7:41 AM >> To: Qiang Zhao <qiang.zhao@nxp.com>; Leo Li <leoyang.li@nxp.com>; >> Christophe Leroy <christophe.leroy@c-s.fr> >> Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; >> linux-kernel@vger.kernel.org; Scott Wood <oss@buserror.net>; Valentin >> Longchamp <valentin.longchamp@keymile.com>; Rasmus Villemoes >> <linux@rasmusvillemoes.dk>; linux-serial@vger.kernel.org >> Subject: [PATCH v2 20/23] serial: make SERIAL_QE depend on PPC32 >> >> Currently SERIAL_QE depends on QUICC_ENGINE, which in turn depends on >> PPC32, so this doesn't add any extra dependency. However, the QUICC >> Engine IP block also exists on some arm boards, so this serves as preparation >> for removing the PPC32 dependency from QUICC_ENGINE and build the QE >> support in drivers/soc/fsl/qe, while preventing allmodconfig/randconfig >> failures due to SERIAL_QE not being supported yet. >> >> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > > I think your purpose of this series is to make the QE UART not depending on PPC32. If it does accomplish that then we don't need this change. Yeah, as I've said in private, I now have the patches to make this work, so this patch (and the later one removing it again) are both gone from my current dev branch. I'll still wait a day or two to allow the ppc people to respond to the inline/OOL iowrite32be issue, but after that I'll resend the whole series. Rasmus
Le 25/10/2019 à 14:40, Rasmus Villemoes a écrit : > Currently SERIAL_QE depends on QUICC_ENGINE, which in turn depends on > PPC32, so this doesn't add any extra dependency. However, the QUICC > Engine IP block also exists on some arm boards, so this serves as > preparation for removing the PPC32 dependency from QUICC_ENGINE and > build the QE support in drivers/soc/fsl/qe, while preventing > allmodconfig/randconfig failures due to SERIAL_QE not being supported > yet. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > --- > drivers/tty/serial/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 67a9eb3f94ce..78246f535809 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1056,6 +1056,7 @@ config SERIAL_LANTIQ > config SERIAL_QE > tristate "Freescale QUICC Engine serial port support" > depends on QUICC_ENGINE > + depends on PPC32 Same, would be more obvious as depends on QUICC_ENGINE && PPC32 Christophe > select SERIAL_CORE > select FW_LOADER > help >
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 67a9eb3f94ce..78246f535809 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1056,6 +1056,7 @@ config SERIAL_LANTIQ config SERIAL_QE tristate "Freescale QUICC Engine serial port support" depends on QUICC_ENGINE + depends on PPC32 select SERIAL_CORE select FW_LOADER help
Currently SERIAL_QE depends on QUICC_ENGINE, which in turn depends on PPC32, so this doesn't add any extra dependency. However, the QUICC Engine IP block also exists on some arm boards, so this serves as preparation for removing the PPC32 dependency from QUICC_ENGINE and build the QE support in drivers/soc/fsl/qe, while preventing allmodconfig/randconfig failures due to SERIAL_QE not being supported yet. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- drivers/tty/serial/Kconfig | 1 + 1 file changed, 1 insertion(+)