media: flexcop-usb: ensure -EIO is returned on error condition
diff mbox series

Message ID
State New
Headers show
  • media: flexcop-usb: ensure -EIO is returned on error condition
Related show

Commit Message

Colin King Oct. 25, 2019, 1:33 p.m. UTC
From: Colin Ian King <>

An earlier commit hard coded a return 0 to function flexcop_usb_i2c_req
even though the an -EIO was intended to be returned in the case where
ret != buflen.  Fix this by replacing the return 0 with the return of
ret to return the error return code

Addresses-Coverity: ("Unused value")
Fixes: b430eaba0be5 ("[media] flexcop-usb: don't use stack for DMA")
Signed-off-by: Colin Ian King <>
 drivers/media/usb/b2c2/flexcop-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

diff --git a/drivers/media/usb/b2c2/flexcop-usb.c b/drivers/media/usb/b2c2/flexcop-usb.c
index 4bf85e9b78b8..917cf4bc08ec 100644
--- a/drivers/media/usb/b2c2/flexcop-usb.c
+++ b/drivers/media/usb/b2c2/flexcop-usb.c
@@ -295,7 +295,7 @@  static int flexcop_usb_i2c_req(struct flexcop_i2c_adapter *i2c,
-	return 0;
+	return ret;
 /* actual bus specific access functions,