[PULL,1/2] virtio-blk: Add blk_drain() to virtio_blk_device_unrealize()
diff mbox series

Message ID 20191025191839.1215-2-stefanha@redhat.com
State New
Headers show
  • [PULL,1/2] virtio-blk: Add blk_drain() to virtio_blk_device_unrealize()
Related show

Commit Message

Stefan Hajnoczi Oct. 25, 2019, 7:18 p.m. UTC
From: Julia Suvorova <jusual@redhat.com>

QEMU does not wait for completed I/O requests, assuming that the guest
driver will reset the device before calling unrealize(). This does not
happen on Windows, and QEMU crashes in virtio_notify(), getting the
result of a completed I/O request on hot-unplugged device.

Signed-off-by: Julia Suvorova <jusual@redhat.com>
Message-Id: <20191018142856.31870-1-jusual@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
 hw/block/virtio-blk.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index ed2ddebd2b..14e9f85b8b 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -1207,6 +1207,7 @@  static void virtio_blk_device_unrealize(DeviceState *dev, Error **errp)
     VirtIODevice *vdev = VIRTIO_DEVICE(dev);
     VirtIOBlock *s = VIRTIO_BLK(dev);
+    blk_drain(s->blk);
     s->dataplane = NULL;