diff mbox series

[1/5] drm/i915: Add two spaces before the SKL_DFSM registers

Message ID 20191026001323.216052-1-jose.souza@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/5] drm/i915: Add two spaces before the SKL_DFSM registers | expand

Commit Message

Souza, Jose Oct. 26, 2019, 12:13 a.m. UTC
The next patches are going to touch this registers so here already
fixing it for older registers and make it consistent with most of
the other registers in this file.

Cc: Ramalingam C <ramalingam.c@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

Comments

Sripada, Radhakrishna Oct. 29, 2019, 6:24 p.m. UTC | #1
On Fri, Oct 25, 2019 at 05:13:19PM -0700, José Roberto de Souza wrote:
> The next patches are going to touch this registers so here already
> fixing it for older registers and make it consistent with most of
> the other registers in this file.
> 
> Cc: Ramalingam C <ramalingam.c@intel.com>
LGTM,
Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 746326784a4d..09cb43f4e976 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -7663,15 +7663,15 @@ enum {
>  #define   CNL_DDI_CLOCK_REG_ACCESS_ON	(1 << 7)
>  
>  #define SKL_DFSM			_MMIO(0x51000)
> -#define SKL_DFSM_CDCLK_LIMIT_MASK	(3 << 23)
> -#define SKL_DFSM_CDCLK_LIMIT_675	(0 << 23)
> -#define SKL_DFSM_CDCLK_LIMIT_540	(1 << 23)
> -#define SKL_DFSM_CDCLK_LIMIT_450	(2 << 23)
> -#define SKL_DFSM_CDCLK_LIMIT_337_5	(3 << 23)
> -#define SKL_DFSM_PIPE_A_DISABLE		(1 << 30)
> -#define SKL_DFSM_PIPE_B_DISABLE		(1 << 21)
> -#define SKL_DFSM_PIPE_C_DISABLE		(1 << 28)
> -#define TGL_DFSM_PIPE_D_DISABLE		(1 << 22)
> +#define   SKL_DFSM_CDCLK_LIMIT_MASK	(3 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_675	(0 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_540	(1 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_450	(2 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_337_5	(3 << 23)
> +#define   SKL_DFSM_PIPE_A_DISABLE	(1 << 30)
> +#define   SKL_DFSM_PIPE_B_DISABLE	(1 << 21)
> +#define   SKL_DFSM_PIPE_C_DISABLE	(1 << 28)
> +#define   TGL_DFSM_PIPE_D_DISABLE	(1 << 22)
>  
>  #define SKL_DSSM				_MMIO(0x51004)
>  #define CNL_DSSM_CDCLK_PLL_REFCLK_24MHz		(1 << 31)
> -- 
> 2.23.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Souza, Jose Oct. 29, 2019, 7:36 p.m. UTC | #2
On Sun, 2019-10-27 at 20:42 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [1/5] drm/i915: Add two spaces before
> the SKL_DFSM registers
> URL   : https://patchwork.freedesktop.org/series/68594/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7191_full -> Patchwork_14995_full
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**
> 
>   No regressions found.

Pushed to dinq, thanks for the reviews Manasi, Ramalingam and RK.

> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in
> Patchwork_14995_full:
> 
> ### IGT changes ###
> 
> #### Suppressed ####
> 
>   The following results come from untrusted machines, tests, or
> statuses.
>   They do not affect the overall result.
> 
>   * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid:
>     - {shard-tglb}:       [PASS][1] -> [INCOMPLETE][2]
>    [1]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-tglb7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid.html
> 
>   
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_14995_full that come from
> known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_eio@unwedge-stress:
>     - shard-snb:          [PASS][3] -> [FAIL][4] ([fdo#109661])
>    [3]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb1/igt@gem_eio@unwedge-stress.html
>    [4]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-snb7/igt@gem_eio@unwedge-stress.html
> 
>   * igt@gem_exec_balancer@smoke:
>     - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#110854])
>    [5]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_balancer@smoke.html
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb8/igt@gem_exec_balancer@smoke.html
> 
>   * igt@gem_exec_create@forked:
>     - shard-kbl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#111626])
>    [7]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl2/igt@gem_exec_create@forked.html
>    [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-kbl2/igt@gem_exec_create@forked.html
> 
>   * igt@gem_exec_parallel@vcs1-fds:
>     - shard-iclb:         [PASS][9] -> [SKIP][10] ([fdo#112080]) +14
> similar issues
>    [9]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb6/igt@gem_exec_parallel@vcs1-fds.html
> 
>   * igt@gem_exec_schedule@promotion-bsd1:
>     - shard-iclb:         [PASS][11] -> [SKIP][12] ([fdo#109276]) +11
> similar issues
>    [11]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
>    [12]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb7/igt@gem_exec_schedule@promotion-bsd1.html
> 
>   * igt@gem_exec_schedule@reorder-wide-bsd:
>     - shard-iclb:         [PASS][13] -> [SKIP][14] ([fdo#111325]) +5
> similar issues
>    [13]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
>    [14]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
> 
>   * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
>     - shard-snb:          [PASS][15] -> [DMESG-WARN][16]
> ([fdo#111870]) +1 similar issue
>    [15]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
>    [16]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
>     - shard-hsw:          [PASS][17] -> [DMESG-WARN][18]
> ([fdo#111870]) +1 similar issue
>    [17]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
>    [18]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
> 
>   * igt@i915_suspend@fence-restore-tiled2untiled:
>     - shard-apl:          [PASS][19] -> [DMESG-WARN][20]
> ([fdo#108566]) +1 similar issue
>    [19]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
>    [20]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
>     - shard-skl:          [PASS][21] -> [FAIL][22] ([fdo#103232])
>    [21]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
>    [22]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
> 
>   * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
>     - shard-skl:          [PASS][23] -> [FAIL][24] ([fdo#102670])
>    [23]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
>    [24]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
> 
>   * igt@kms_flip@flip-vs-suspend:
>     - shard-skl:          [PASS][25] -> [INCOMPLETE][26]
> ([fdo#109507])
>    [25]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl1/igt@kms_flip@flip-vs-suspend.html
>    [26]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-skl1/igt@kms_flip@flip-vs-suspend.html
>     - shard-hsw:          [PASS][27] -> [INCOMPLETE][28]
> ([fdo#103540])
>    [27]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw6/igt@kms_flip@flip-vs-suspend.html
>    [28]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-hsw4/igt@kms_flip@flip-vs-suspend.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-suspend:
>     - shard-kbl:          [PASS][29] -> [DMESG-WARN][30]
> ([fdo#108566]) +9 similar issues
>    [29]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
>    [30]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
>     - shard-iclb:         [PASS][31] -> [INCOMPLETE][32]
> ([fdo#107713])
>    [31]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-suspend.html
>    [32]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-suspend.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
>     - shard-iclb:         [PASS][33] -> [FAIL][34] ([fdo#103167]) +2
> similar issues
>    [33]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
>    [34]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
> 
>   * igt@kms_psr@psr2_sprite_render:
>     - shard-iclb:         [PASS][35] -> [SKIP][36] ([fdo#109441])
>    [35]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
>    [36]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb6/igt@kms_psr@psr2_sprite_render.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_ctx_isolation@vcs1-clean:
>     - shard-iclb:         [SKIP][37] ([fdo#109276] / [fdo#112080]) ->
> [PASS][38] +1 similar issue
>    [37]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb6/igt@gem_ctx_isolation@vcs1-clean.html
>    [38]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb1/igt@gem_ctx_isolation@vcs1-clean.html
> 
>   * igt@gem_ctx_isolation@vecs0-s3:
>     - {shard-tglb}:       [INCOMPLETE][39] ([fdo#111832]) ->
> [PASS][40]
>    [39]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb2/igt@gem_ctx_isolation@vecs0-s3.html
>    [40]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-tglb5/igt@gem_ctx_isolation@vecs0-s3.html
>     - shard-kbl:          [DMESG-WARN][41] ([fdo#108566]) ->
> [PASS][42]
>    [41]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl2/igt@gem_ctx_isolation@vecs0-s3.html
>    [42]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-kbl4/igt@gem_ctx_isolation@vecs0-s3.html
> 
>   * igt@gem_ctx_shared@q-smoketest-all:
>     - {shard-tglb}:       [INCOMPLETE][43] ([fdo#111735]) ->
> [PASS][44]
>    [43]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb3/igt@gem_ctx_shared@q-smoketest-all.html
>    [44]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-tglb4/igt@gem_ctx_shared@q-smoketest-all.html
> 
>   * igt@gem_ctx_shared@q-smoketest-render:
>     - {shard-tglb}:       [INCOMPLETE][45] ([fdo# 111852 ]) ->
> [PASS][46] +2 similar issues
>    [45]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@gem_ctx_shared@q-smoketest-render.html
>    [46]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-tglb1/igt@gem_ctx_shared@q-smoketest-render.html
> 
>   * igt@gem_eio@reset-stress:
>     - shard-apl:          [INCOMPLETE][47] ([fdo#103927]) ->
> [PASS][48] +1 similar issue
>    [47]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@gem_eio@reset-stress.html
>    [48]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-apl8/igt@gem_eio@reset-stress.html
> 
>   * igt@gem_exec_schedule@preempt-other-chain-bsd:
>     - shard-iclb:         [SKIP][49] ([fdo#111325]) -> [PASS][50] +5
> similar issues
>    [49]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
>    [50]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> 
>   * igt@gem_exec_schedule@preempt-queue-bsd1:
>     - shard-iclb:         [SKIP][51] ([fdo#109276]) -> [PASS][52] +8
> similar issues
>    [51]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html
>    [52]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
> 
>   * igt@gem_reg_read@timestamp-monotonic:
>     - {shard-tglb}:       [INCOMPLETE][53] -> [PASS][54]
>    [53]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb3/igt@gem_reg_read@timestamp-monotonic.html
>    [54]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-tglb7/igt@gem_reg_read@timestamp-monotonic.html
> 
>   * igt@gem_userptr_blits@sync-unmap-after-close:
>     - shard-hsw:          [DMESG-WARN][55] ([fdo#111870]) ->
> [PASS][56] +1 similar issue
>    [55]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw5/igt@gem_userptr_blits@sync-unmap-after-close.html
>    [56]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-hsw5/igt@gem_userptr_blits@sync-unmap-after-close.html
> 
>   * igt@gem_userptr_blits@sync-unmap-cycles:
>     - shard-snb:          [DMESG-WARN][57] ([fdo#111870]) ->
> [PASS][58] +1 similar issue
>    [57]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
>    [58]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
> 
>   * igt@i915_pm_rpm@cursor:
>     - shard-skl:          [DMESG-WARN][59] ([fdo#105541]) ->
> [PASS][60]
>    [59]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl10/igt@i915_pm_rpm@cursor.html
>    [60]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-skl2/igt@i915_pm_rpm@cursor.html
> 
>   * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
>     - {shard-tglb}:       [FAIL][61] ([fdo#102670]) -> [PASS][62]
>    [61]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
>    [62]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
> 
>   * igt@kms
> _frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
>     - shard-iclb:         [FAIL][63] ([fdo#103167]) -> [PASS][64] +3
> similar issues
>    [63]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
>    [64]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt:
>     - {shard-tglb}:       [FAIL][65] ([fdo#103167]) -> [PASS][66] +3
> similar issues
>    [65]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html
>    [66]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html
> 
>   * igt@kms_setmode@basic:
>     - shard-kbl:          [FAIL][67] ([fdo#99912]) -> [PASS][68]
>    [67]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl1/igt@kms_setmode@basic.html
>    [68]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-kbl2/igt@kms_setmode@basic.html
> 
>   * igt@perf_pmu@busy-vcs1:
>     - shard-iclb:         [SKIP][69] ([fdo#112080]) -> [PASS][70] +5
> similar issues
>    [69]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb5/igt@perf_pmu@busy-vcs1.html
>    [70]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb2/igt@perf_pmu@busy-vcs1.html
> 
>   
> #### Warnings ####
> 
>   * igt@gem_mocs_settings@mocs-settings-bsd2:
>     - shard-iclb:         [SKIP][71] ([fdo#109276]) -> [FAIL][72]
> ([fdo#111330]) +2 similar issues
>    [71]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb8/igt@gem_mocs_settings@mocs-settings-bsd2.html
>    [72]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb2/igt@gem_mocs_settings@mocs-settings-bsd2.html
> 
>   * igt@kms_dp_dsc@basic-dsc-enable-edp:
>     - shard-iclb:         [SKIP][73] ([fdo#109349]) -> [DMESG-
> WARN][74] ([fdo#107724])
>    [73]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb5/igt@kms_dp_dsc@basic-dsc-enable-edp.html
>    [74]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
> 
>   * igt@kms_psr@psr2_suspend:
>     - shard-iclb:         [SKIP][75] ([fdo#109441]) -> [DMESG-
> WARN][76] ([fdo#107724])
>    [75]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_psr@psr2_suspend.html
>    [76]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/shard-iclb2/igt@kms_psr@psr2_suspend.html
> 
>   
>   {name}: This element is suppressed. This means it is ignored when
> computing
>           the status of the difference (SUCCESS, WARNING, or
> FAILURE).
> 
>   [fdo# 111852 ]: https://bugs.freedesktop.org/show_bug.cgi?id=
> 111852 
>   [fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>   [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
>   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
>   [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
>   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>   [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
>   [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
>   [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
>   [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
>   [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
>   [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
>   [fdo#111626]: https://bugs.freedesktop.org/show_bug.cgi?id=111626
>   [fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
>   [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
>   [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
>   [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
>   [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
>   [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
>   [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
>   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> 
> 
> Participating hosts (11 -> 11)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_7191 -> Patchwork_14995
> 
>   CI-20190529: 20190529
>   CI_DRM_7191: 59c58784011dbec9a742d33b3d8d673393b95112 @
> git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5242: 15c11e2df77f769b5fa9ca5b40a94f266370a479 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_14995: e5445576f2ca5f65def63ce3246b6ba3a267cfa6 @
> git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14995/index.html
Ramalingam C Nov. 1, 2019, 4:44 a.m. UTC | #3
On 2019-10-25 at 17:13:19 -0700, José Roberto de Souza wrote:
> The next patches are going to touch this registers so here already
> fixing it for older registers and make it consistent with most of
> the other registers in this file.
> 
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 746326784a4d..09cb43f4e976 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -7663,15 +7663,15 @@ enum {
>  #define   CNL_DDI_CLOCK_REG_ACCESS_ON	(1 << 7)
>  
>  #define SKL_DFSM			_MMIO(0x51000)
> -#define SKL_DFSM_CDCLK_LIMIT_MASK	(3 << 23)
> -#define SKL_DFSM_CDCLK_LIMIT_675	(0 << 23)
> -#define SKL_DFSM_CDCLK_LIMIT_540	(1 << 23)
> -#define SKL_DFSM_CDCLK_LIMIT_450	(2 << 23)
> -#define SKL_DFSM_CDCLK_LIMIT_337_5	(3 << 23)
> -#define SKL_DFSM_PIPE_A_DISABLE		(1 << 30)
> -#define SKL_DFSM_PIPE_B_DISABLE		(1 << 21)
> -#define SKL_DFSM_PIPE_C_DISABLE		(1 << 28)
> -#define TGL_DFSM_PIPE_D_DISABLE		(1 << 22)
> +#define   SKL_DFSM_CDCLK_LIMIT_MASK	(3 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_675	(0 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_540	(1 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_450	(2 << 23)
> +#define   SKL_DFSM_CDCLK_LIMIT_337_5	(3 << 23)
> +#define   SKL_DFSM_PIPE_A_DISABLE	(1 << 30)
> +#define   SKL_DFSM_PIPE_B_DISABLE	(1 << 21)
> +#define   SKL_DFSM_PIPE_C_DISABLE	(1 << 28)
> +#define   TGL_DFSM_PIPE_D_DISABLE	(1 << 22)
Looks good to me.

Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
>  
>  #define SKL_DSSM				_MMIO(0x51004)
>  #define CNL_DSSM_CDCLK_PLL_REFCLK_24MHz		(1 << 31)
> -- 
> 2.23.0
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 746326784a4d..09cb43f4e976 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -7663,15 +7663,15 @@  enum {
 #define   CNL_DDI_CLOCK_REG_ACCESS_ON	(1 << 7)
 
 #define SKL_DFSM			_MMIO(0x51000)
-#define SKL_DFSM_CDCLK_LIMIT_MASK	(3 << 23)
-#define SKL_DFSM_CDCLK_LIMIT_675	(0 << 23)
-#define SKL_DFSM_CDCLK_LIMIT_540	(1 << 23)
-#define SKL_DFSM_CDCLK_LIMIT_450	(2 << 23)
-#define SKL_DFSM_CDCLK_LIMIT_337_5	(3 << 23)
-#define SKL_DFSM_PIPE_A_DISABLE		(1 << 30)
-#define SKL_DFSM_PIPE_B_DISABLE		(1 << 21)
-#define SKL_DFSM_PIPE_C_DISABLE		(1 << 28)
-#define TGL_DFSM_PIPE_D_DISABLE		(1 << 22)
+#define   SKL_DFSM_CDCLK_LIMIT_MASK	(3 << 23)
+#define   SKL_DFSM_CDCLK_LIMIT_675	(0 << 23)
+#define   SKL_DFSM_CDCLK_LIMIT_540	(1 << 23)
+#define   SKL_DFSM_CDCLK_LIMIT_450	(2 << 23)
+#define   SKL_DFSM_CDCLK_LIMIT_337_5	(3 << 23)
+#define   SKL_DFSM_PIPE_A_DISABLE	(1 << 30)
+#define   SKL_DFSM_PIPE_B_DISABLE	(1 << 21)
+#define   SKL_DFSM_PIPE_C_DISABLE	(1 << 28)
+#define   TGL_DFSM_PIPE_D_DISABLE	(1 << 22)
 
 #define SKL_DSSM				_MMIO(0x51004)
 #define CNL_DSSM_CDCLK_PLL_REFCLK_24MHz		(1 << 31)