[1/2] drm/i915/uc: define GuC and HuC binaries for TGL
diff mbox series

Message ID 20191026003507.21769-1-daniele.ceraolospurio@intel.com
State New
Headers show
Series
  • [1/2] drm/i915/uc: define GuC and HuC binaries for TGL
Related show

Commit Message

Daniele Ceraolo Spurio Oct. 26, 2019, 12:35 a.m. UTC
GuC 35.2.0 and HuC 7.0.3 are the first production releases for TGL.
GuC 35.2 for gen12 is interface-compatible with 33.0 on older gens,
because the differences are related to additional blocks/commands in
the interface to support new Gen12 features. These parts of the
interface will be added when the relevant features are enabled.

Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Michal Wajdeczko Oct. 26, 2019, 10:44 a.m. UTC | #1
On Sat, 26 Oct 2019 02:35:06 +0200, Daniele Ceraolo Spurio  
<daniele.ceraolospurio@intel.com> wrote:

> GuC 35.2.0 and HuC 7.0.3 are the first production releases for TGL.
> GuC 35.2 for gen12 is interface-compatible with 33.0 on older gens,
> because the differences are related to additional blocks/commands in
> the interface to support new Gen12 features. These parts of the
> interface will be added when the relevant features are enabled.
>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c  
> b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> index bb4889d2346d..09201f12f5cc 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> @@ -37,8 +37,13 @@ void intel_uc_fw_change_status(struct intel_uc_fw  
> *uc_fw,
>  /*
>   * List of required GuC and HuC binaries per-platform.
>   * Must be ordered based on platform + revid, from newer to older.
> + *
> + * TGL 35.2 is interface-compatible with 33.0 for previous gens. The  
> deltas
> + * between 33.0 and 35.2 are only related to new additions to support  
> new gen12
> + * features.

nit: s/gen12/Gen12 (same for "gens"), here and in the commit message

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

Thanks,
Michal
Daniele Ceraolo Spurio Oct. 30, 2019, 10:52 p.m. UTC | #2
On 10/26/19 3:44 AM, Michal Wajdeczko wrote:
> On Sat, 26 Oct 2019 02:35:06 +0200, Daniele Ceraolo Spurio 
> <daniele.ceraolospurio@intel.com> wrote:
> 
>> GuC 35.2.0 and HuC 7.0.3 are the first production releases for TGL.
>> GuC 35.2 for gen12 is interface-compatible with 33.0 on older gens,
>> because the differences are related to additional blocks/commands in
>> the interface to support new Gen12 features. These parts of the
>> interface will be added when the relevant features are enabled.
>>
>> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> ---
>>  drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c 
>> b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
>> index bb4889d2346d..09201f12f5cc 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
>> @@ -37,8 +37,13 @@ void intel_uc_fw_change_status(struct intel_uc_fw 
>> *uc_fw,
>>  /*
>>   * List of required GuC and HuC binaries per-platform.
>>   * Must be ordered based on platform + revid, from newer to older.
>> + *
>> + * TGL 35.2 is interface-compatible with 33.0 for previous gens. The 
>> deltas
>> + * between 33.0 and 35.2 are only related to new additions to support 
>> new gen12
>> + * features.
> 
> nit: s/gen12/Gen12 (same for "gens"), here and in the commit message
> 
> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> 

Both blobs are loading fine in CI, so fixed the typos and pushed.

Thanks,
Daniele

> Thanks,
> Michal

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
index bb4889d2346d..09201f12f5cc 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
@@ -37,8 +37,13 @@  void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
 /*
  * List of required GuC and HuC binaries per-platform.
  * Must be ordered based on platform + revid, from newer to older.
+ *
+ * TGL 35.2 is interface-compatible with 33.0 for previous gens. The deltas
+ * between 33.0 and 35.2 are only related to new additions to support new gen12
+ * features.
  */
 #define INTEL_UC_FIRMWARE_DEFS(fw_def, guc_def, huc_def) \
+	fw_def(TIGERLAKE,   0, guc_def(tgl, 35, 2, 0), huc_def(tgl,  7, 0, 3)) \
 	fw_def(ELKHARTLAKE, 0, guc_def(ehl, 33, 0, 4), huc_def(ehl,  9, 0, 0)) \
 	fw_def(ICELAKE,     0, guc_def(icl, 33, 0, 0), huc_def(icl,  9, 0, 0)) \
 	fw_def(COFFEELAKE,  5, guc_def(cml, 33, 0, 0), huc_def(cml,  4, 0, 0)) \