lib/color_encoding: Fix up support for XYUV format.
diff mbox series

Message ID 20191028212459.1998-1-bob.j.paauwe@intel.com
State New
Headers show
Series
  • lib/color_encoding: Fix up support for XYUV format.
Related show

Commit Message

Bob Paauwe Oct. 28, 2019, 9:24 p.m. UTC
Add XYUV8888 to the list of DRM Formats to test.

Also fix the byte order for the format.

Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
---
 lib/igt_color_encoding.c | 1 +
 lib/igt_fb.c             | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

Comments

Matt Roper Oct. 30, 2019, 7:20 p.m. UTC | #1
On Mon, Oct 28, 2019 at 02:24:59PM -0700, Bob Paauwe wrote:
> Add XYUV8888 to the list of DRM Formats to test.
> 
> Also fix the byte order for the format.
> 
> Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>

Looks like CI got confused by this.  You'll want to

Cc: igt-dev@lists.freedesktop.org

and also set your subjectPrefix to "PATCH i-g-t" so that CI recognizes
it as an igt patch and not a kernel patch.


Matt

> ---
>  lib/igt_color_encoding.c | 1 +
>  lib/igt_fb.c             | 6 +++---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_color_encoding.c b/lib/igt_color_encoding.c
> index 7de6d5ab..a7bd2b22 100644
> --- a/lib/igt_color_encoding.c
> +++ b/lib/igt_color_encoding.c
> @@ -160,6 +160,7 @@ static const struct color_encoding_format {
>  	{ DRM_FORMAT_XVYU2101010, 1023.f, 64.f, 940.f, 64.f, 512.f, 960.f },
>  	{ DRM_FORMAT_XVYU12_16161616, 65520.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
>  	{ DRM_FORMAT_XVYU16161616, 65535.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
> +	{ DRM_FORMAT_XYUV8888, 255.f, 16.f, 235.f, 16.f, 128.f, 240.f },
>  };
>  
>  static const struct color_encoding_format *lookup_fourcc(uint32_t fourcc)
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 4adca967..fe5fa74b 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -2423,9 +2423,9 @@ static void get_yuv_parameters(struct igt_fb *fb, struct yuv_parameters *params)
>  		break;
>  
>  	case DRM_FORMAT_XYUV8888:
> -		params->y_offset = fb->offsets[0] + 1;
> -		params->u_offset = fb->offsets[0] + 2;
> -		params->v_offset = fb->offsets[0] + 3;
> +		params->y_offset = fb->offsets[0] + 2;
> +		params->u_offset = fb->offsets[0] + 1;
> +		params->v_offset = fb->offsets[0] + 0;
>  		break;
>  	}
>  }
> -- 
> 2.21.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patch
diff mbox series

diff --git a/lib/igt_color_encoding.c b/lib/igt_color_encoding.c
index 7de6d5ab..a7bd2b22 100644
--- a/lib/igt_color_encoding.c
+++ b/lib/igt_color_encoding.c
@@ -160,6 +160,7 @@  static const struct color_encoding_format {
 	{ DRM_FORMAT_XVYU2101010, 1023.f, 64.f, 940.f, 64.f, 512.f, 960.f },
 	{ DRM_FORMAT_XVYU12_16161616, 65520.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
 	{ DRM_FORMAT_XVYU16161616, 65535.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
+	{ DRM_FORMAT_XYUV8888, 255.f, 16.f, 235.f, 16.f, 128.f, 240.f },
 };
 
 static const struct color_encoding_format *lookup_fourcc(uint32_t fourcc)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 4adca967..fe5fa74b 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -2423,9 +2423,9 @@  static void get_yuv_parameters(struct igt_fb *fb, struct yuv_parameters *params)
 		break;
 
 	case DRM_FORMAT_XYUV8888:
-		params->y_offset = fb->offsets[0] + 1;
-		params->u_offset = fb->offsets[0] + 2;
-		params->v_offset = fb->offsets[0] + 3;
+		params->y_offset = fb->offsets[0] + 2;
+		params->u_offset = fb->offsets[0] + 1;
+		params->v_offset = fb->offsets[0] + 0;
 		break;
 	}
 }